accounts: assert no startup error in tests

ellemouton · ellemouton · commit ef78bc4d9d9b · 2025-01-23T09:20:09.000+02:00
In the case where no startup error is expected, we should assert that no
error is returned from Start.
diff --git a/accounts/service_test.go b/accounts/service_test.go
@@ -372,6 +372,7 @@ func TestAccountService(t *testing.T) {
 
 			return []AccountID{acct.ID}
 		},
+		startupErr: testErr.Error(),
 		validate: func(t *testing.T, lnd *mockLnd, r *mockRouter,
 			ids []AccountID, s *InterceptorService) {
 
@@ -852,6 +853,8 @@ func TestAccountService(t *testing.T) {
 				}
 
 				return
+			} else {
+				require.NoError(t, err)
 			}
 
 			// Any post execution validation that we need to run?

Original file line number	Diff line number	Diff line change
`@@ -372,6 +372,7 @@ func TestAccountService(t *testing.T) {`
`372`	`372`
`373`	`373`	`return []AccountID{acct.ID}`
`374`	`374`	`},`
	`375`	`+ startupErr: testErr.Error(),`
`375`	`376`	`validate: func(t testing.T, lnd mockLnd, r *mockRouter,`
`376`	`377`	`ids []AccountID, s *InterceptorService) {`
`377`	`378`
`@@ -852,6 +853,8 @@ func TestAccountService(t *testing.T) {`
`852`	`853`	`}`
`853`	`854`
`854`	`855`	`return`
	`856`	`+ } else {`
	`857`	`+ require.NoError(t, err)`
`855`	`858`	`}`
`856`	`859`
`857`	`860`	`// Any post execution validation that we need to run?`