Skip to content

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented Mar 11, 2025

This PR does 1 main things:

  1. updates various of the rule db kv-store interfaces to take contexts and then threads contexts through where necessary.
  2. creates a generic DBExecutor interface and use init the KVStores interface. Later on we will use it to replace the PrivacyMap interface too.

part of #917

Here we introduce a generic DBExecutor interface with methods that take
a generic T transaction. This is in preparation for the introducing a
SQL transaction instead of a bolt one.
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥!

@ellemouton ellemouton merged commit 1462832 into lightninglabs:master Mar 13, 2025
20 of 21 checks passed
@ellemouton ellemouton deleted the sql23 branch March 13, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR is does not require a release notes entry sql-ize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants