multi: fix linter issues after version update

Author: guggero

lightning_client_test.go

@@ -161,7 +161,6 @@ func TestLightningClientAddInvoice(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			ln := lightningClient{
 				client: &test.client,

lnd_services_test.go

@@ -154,7 +154,6 @@ func TestLndVersionCheckComparison(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			err := AssertVersionCompatible(
 				tc.actual, &verrpc.Version{
@@ -311,8 +310,6 @@ func TestGetLndInfo(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		t.Run(test.name, func(t *testing.T) {
 			mock := newLockLndMock(
 				test.errors, test.stateErr, test.states,

macaroon_recipes_test.go

@@ -73,7 +73,6 @@ func TestMacaroonRecipe(t *testing.T) {
 
 	// Run the test for all supported RPC packages.
 	for pkg, numPermissions := range expectedPermissions {
-		pkg, numPermissions := pkg, numPermissions
 		t.Run(pkg, func(t *testing.T) {
 			t.Parallel()
 

router_client.go

@@ -1061,7 +1061,6 @@ func (r *routerClient) ImportMissionControl(ctx context.Context,
 	}
 
 	for i, entry := range entries {
-		entry := entry
 		rpcEntry := &routerrpc.PairHistory{
 			NodeFrom: entry.NodeFrom[:],
 			NodeTo:   entry.NodeTo[:],

walletkit_client.go

@@ -357,8 +357,6 @@ func (m *walletKitClient) ListLeases(ctx context.Context) ([]LeaseDescriptor,
 
 	leases := make([]LeaseDescriptor, 0, len(resp.LockedUtxos))
 	for _, leasedUtxo := range resp.LockedUtxos {
-		leasedUtxo := leasedUtxo
-
 		txHash, err := chainhash.NewHash(
 			leasedUtxo.Outpoint.TxidBytes,
 		)