lndclient: Use TrimSuffix instead of ReplaceAll

Use strings.TrimSuffix instead of strings.ReplaceAll in the macaroon
recipe code. This is necessary because the WtClient macaroon name
contains the word "client" and would be malformed in the old code.
New code just removes the last "client".

Signed-off-by: Jonathan <[email protected]>

Author: Jontified

macaroon_recipes.go

@@ -77,7 +77,7 @@ func MacaroonRecipe(c LightningClient, packages []string) ([]MacaroonPermission,
 		// From the pointer type we can find out the interface, its name
 		// and what methods it declares.
 		ifaceType := reflect.TypeOf(ifacePtr).Elem()
-		serverName := strings.ReplaceAll(ifaceType.Name(), "Client", "")
+		serverName := strings.TrimSuffix(ifaceType.Name(), "Client")
 		for i := range ifaceType.NumMethod() {
 			// The methods in lndclient might be called slightly
 			// differently. Rename according to our rename mapping