multi: fix most obvious linter errors

guggero · guggero · commit 36838cf7f464 · 2019-10-09T14:35:41.000+02:00
diff --git a/client.go b/client.go
@@ -384,7 +384,7 @@ func (s *Client) LoopOutQuote(ctx context.Context,
 	return &LoopOutQuote{
 		SwapFee:         swapFee,
 		MinerFee:        minerFee,
-		PrepayAmount:    btcutil.Amount(quote.PrepayAmount),
+		PrepayAmount:    quote.PrepayAmount,
 		SwapPaymentDest: quote.SwapPaymentDest,
 		CltvDelta:       quote.CltvDelta,
 	}, nil
diff --git a/cmd/loop/loopin.go b/cmd/loop/loopin.go
@@ -41,8 +41,7 @@ func loopIn(ctx *cli.Context) error {
 		args = args.Tail()
 	default:
 		// Show command help if no arguments and flags were provided.
-		cli.ShowCommandHelp(ctx, "in")
-		return nil
+		return cli.ShowCommandHelp(ctx, "in")
 	}
 
 	amt, err := parseAmt(amtStr)
diff --git a/cmd/loop/loopout.go b/cmd/loop/loopout.go
@@ -59,8 +59,7 @@ func loopOut(ctx *cli.Context) error {
 		args = args.Tail()
 	default:
 		// Show command help if no arguments and flags were provided.
-		cli.ShowCommandHelp(ctx, "out")
-		return nil
+		return cli.ShowCommandHelp(ctx, "out")
 	}
 
 	amt, err := parseAmt(amtStr)
diff --git a/cmd/loop/main.go b/cmd/loop/main.go
@@ -97,7 +97,7 @@ type limits struct {
 }
 
 func getLimits(amt btcutil.Amount, quote *looprpc.QuoteResponse) *limits {
-	maxSwapRoutingFee := getMaxRoutingFee(btcutil.Amount(amt))
+	maxSwapRoutingFee := getMaxRoutingFee(amt)
 	maxPrepayRoutingFee := getMaxRoutingFee(btcutil.Amount(
 		quote.PrepayAmt,
 	))
@@ -126,7 +126,7 @@ func displayLimits(swapType loop.Type, amt btcutil.Amount, l *limits,
 	if l.maxPrepayRoutingFee != nil {
 		totalSuccessMax += *l.maxPrepayRoutingFee
 	}
-	
+
 	if swapType == loop.TypeIn && externalHtlc {
 		fmt.Printf("On-chain fee for external loop in is not " +
 			"included.\nSufficient fees will need to be paid " +
@@ -135,7 +135,7 @@ func displayLimits(swapType loop.Type, amt btcutil.Amount, l *limits,
 	}
 
 	fmt.Printf("Max swap fees for %d Loop %v: %d\n",
-		btcutil.Amount(amt), swapType, totalSuccessMax,
+		amt, swapType, totalSuccessMax,
 	)
 
 	fmt.Printf("CONTINUE SWAP? (y/n), expand fee detail (x): ")
diff --git a/cmd/loop/quote.go b/cmd/loop/quote.go
@@ -28,8 +28,7 @@ func quote(ctx *cli.Context) error {
 	// Show command help if the incorrect number arguments and/or flags were
 	// provided.
 	if ctx.NArg() != 1 || ctx.NumFlags() > 1 {
-		cli.ShowCommandHelp(ctx, "quote")
-		return nil
+		return cli.ShowCommandHelp(ctx, "quote")
 	}
 
 	args := ctx.Args()
diff --git a/executor.go b/executor.go
@@ -69,7 +69,7 @@ func (s *executor) run(mainCtx context.Context,
 
 	select {
 	case h := <-blockEpochChan:
-		setHeight(int32(h))
+		setHeight(h)
 	case err := <-blockErrorChan:
 		return err
 	case <-mainCtx.Done():
@@ -134,10 +134,10 @@ func (s *executor) run(mainCtx context.Context,
 			delete(blockEpochQueues, doneID)
 
 		case h := <-blockEpochChan:
-			setHeight(int32(h))
+			setHeight(h)
 			for _, queue := range blockEpochQueues {
 				select {
-				case queue.ChanIn() <- int32(h):
+				case queue.ChanIn() <- h:
 				case <-mainCtx.Done():
 					return mainCtx.Err()
 				}
diff --git a/lndclient/invoices_client.go b/lndclient/invoices_client.go
@@ -52,10 +52,10 @@ func (s *invoicesClient) WaitForFinished() {
 func (s *invoicesClient) SettleInvoice(ctx context.Context,
 	preimage lntypes.Preimage) error {
 
-	rpcCtx, cancel := context.WithTimeout(ctx, rpcTimeout)
+	timeoutCtx, cancel := context.WithTimeout(ctx, rpcTimeout)
 	defer cancel()
 
-	rpcCtx = s.invoiceMac.WithMacaroonAuth(ctx)
+	rpcCtx := s.invoiceMac.WithMacaroonAuth(timeoutCtx)
 	_, err := s.client.SettleInvoice(rpcCtx, &invoicesrpc.SettleInvoiceMsg{
 		Preimage: preimage[:],
 	})
diff --git a/lndclient/log.go b/lndclient/log.go
@@ -1,8 +1,9 @@
 package lndclient
 
 import (
-	"github.com/btcsuite/btclog"
 	"os"
+
+	"github.com/btcsuite/btclog"
 )
 
 // log is a logger that is initialized with no output filters.  This
diff --git a/lndclient/router_client.go b/lndclient/router_client.go
@@ -4,9 +4,10 @@ import (
 	"context"
 	"encoding/hex"
 	"fmt"
+	"time"
+
 	"github.com/lightningnetwork/lnd/lnrpc"
 	"github.com/lightningnetwork/lnd/routing/route"
-	"time"
 
 	"github.com/lightningnetwork/lnd/channeldb"
 	"google.golang.org/grpc/codes"
diff --git a/log.go b/log.go
@@ -12,9 +12,8 @@ import (
 // means the package will not perform any logging by default until the caller
 // requests it.
 var (
-	backendLog     = btclog.NewBackend(logWriter{})
-	logger         = backendLog.Logger("CLIENT")
-	servicesLogger = backendLog.Logger("SERVICES")
+	backendLog = btclog.NewBackend(logWriter{})
+	logger     = backendLog.Logger("CLIENT")
 )
 
 // logWriter implements an io.Writer that outputs to both standard output and
diff --git a/loopdb/loopin.go b/loopdb/loopin.go
@@ -127,7 +127,10 @@ func deserializeLoopInContract(value []byte) (*LoopInContract, error) {
 		return nil, err
 	}
 
-	binary.Read(r, byteOrder, &contract.AmountRequested)
+	err = binary.Read(r, byteOrder, &contract.AmountRequested)
+	if err != nil {
+		return nil, err
+	}
 
 	n, err := r.Read(contract.SenderKey[:])
 	if err != nil {
diff --git a/loopdb/loopout.go b/loopdb/loopout.go
@@ -84,7 +84,10 @@ func deserializeLoopOutContract(value []byte, chainParams *chaincfg.Params) (
 		return nil, err
 	}
 
-	binary.Read(r, byteOrder, &contract.AmountRequested)
+	err = binary.Read(r, byteOrder, &contract.AmountRequested)
+	if err != nil {
+		return nil, err
+	}
 
 	contract.PrepayInvoice, err = wire.ReadVarString(r, 0)
 	if err != nil {
diff --git a/loopin.go b/loopin.go
@@ -493,7 +493,7 @@ func (s *loopInSwap) waitForSwapComplete(ctx context.Context,
 		case err := <-swapInvoiceErr:
 			return err
 
-		// An update to the swap invoice occured. Check the new state
+		// An update to the swap invoice occurred. Check the new state
 		// and update the swap state accordingly.
 		case update := <-swapInvoiceChan:
 			s.log.Infof("Received swap invoice update: %v",
diff --git a/loopout_test.go b/loopout_test.go
@@ -176,7 +176,7 @@ func TestCustomSweepConfTarget(t *testing.T) {
 	// Notify the confirmation notification for the HTLC.
 	ctx.AssertRegisterConf()
 
-	blockEpochChan <- int32(ctx.Lnd.Height + 1)
+	blockEpochChan <- ctx.Lnd.Height + 1
 
 	htlcTx := wire.NewMsgTx(2)
 	htlcTx.AddTxOut(&wire.TxOut{
@@ -238,7 +238,7 @@ func TestCustomSweepConfTarget(t *testing.T) {
 
 	// The sweep should have a fee that corresponds to the custom
 	// confirmation target.
-	sweepTx := assertSweepTx(testRequest.SweepConfTarget)
+	_ = assertSweepTx(testRequest.SweepConfTarget)
 
 	// We'll then notify the height at which we begin using the default
 	// confirmation target.
@@ -249,7 +249,7 @@ func TestCustomSweepConfTarget(t *testing.T) {
 
 	// We should expect to see another sweep using the higher fee since the
 	// spend hasn't been confirmed yet.
-	sweepTx = assertSweepTx(DefaultSweepConfTarget)
+	sweepTx := assertSweepTx(DefaultSweepConfTarget)
 
 	// Notify the spend so that the swap reaches its final state.
 	ctx.NotifySpend(sweepTx, 0)
diff --git a/server_mock_test.go b/server_mock_test.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 
-	"testing"
 	"time"
 
 	"github.com/btcsuite/btcd/chaincfg"
@@ -20,20 +19,14 @@ var (
 
 	testLoopOutOnChainCltvDelta = int32(30)
 	testChargeOnChainCltvDelta  = int32(100)
-	testCltvDelta               = 50
 	testSwapFee                 = btcutil.Amount(210)
-	testInvoiceExpiry           = 180 * time.Second
 	testFixedPrepayAmount       = btcutil.Amount(100)
 	testMinSwapAmount           = btcutil.Amount(10000)
 	testMaxSwapAmount           = btcutil.Amount(1000000)
-	testTxConfTarget            = 2
-	testRepublishDelay          = 10 * time.Second
 )
 
 // serverMock is used in client unit tests to simulate swap server behaviour.
 type serverMock struct {
-	t *testing.T
-
 	expectedSwapAmt  btcutil.Amount
 	swapInvoiceAmt   btcutil.Amount
 	prepayInvoiceAmt btcutil.Amount
diff --git a/store_mock_test.go b/store_mock_test.go
@@ -25,11 +25,6 @@ type storeMock struct {
 	t *testing.T
 }
 
-type finishData struct {
-	preimage lntypes.Hash
-	result   loopdb.SwapState
-}
-
 // NewStoreMock instantiates a new mock store.
 func newStoreMock(t *testing.T) *storeMock {
 	return &storeMock{
diff --git a/sweep/sweeper.go b/sweep/sweeper.go
@@ -112,7 +112,7 @@ func (s *Sweeper) GetSweepFee(ctx context.Context,
 	case *btcutil.AddressPubKeyHash:
 		weightEstimate.AddP2PKHOutput()
 	default:
-		return 0, fmt.Errorf("unknown adress type %T", destAddr)
+		return 0, fmt.Errorf("unknown address type %T", destAddr)
 	}
 
 	addInputEstimate(&weightEstimate)
diff --git a/test/log.go b/test/log.go
@@ -1,8 +1,9 @@
 package test
 
 import (
-	"github.com/btcsuite/btclog"
 	"os"
+
+	"github.com/btcsuite/btclog"
 )
 
 // log is a logger that is initialized with no output filters.  This
diff --git a/test/testutils.go b/test/testutils.go
@@ -91,5 +91,8 @@ func GetInvoice(hash lntypes.Hash, amt btcutil.Amount, memo string) (
 
 // DumpGoroutines dumps all currently running goroutines.
 func DumpGoroutines() {
-	pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+	err := pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+	if err != nil {
+		panic(err)
+	}
 }
diff --git a/test/timeout.go b/test/timeout.go
@@ -15,7 +15,10 @@ func Guard(t *testing.T) func() {
 	go func() {
 		select {
 		case <-time.After(5 * time.Second):
-			pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+			err := pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+			if err != nil {
+				panic(err)
+			}
 
 			panic("test timeout")
 		case <-done:
diff --git a/testcontext_test.go b/testcontext_test.go
@@ -21,14 +21,6 @@ var (
 		1, 1, 1, 1, 2, 2, 2, 2,
 		3, 3, 3, 3, 4, 4, 4, 4,
 	})
-	testPrepayPreimage = lntypes.Preimage([32]byte{
-		1, 1, 1, 1, 2, 2, 2, 2,
-		3, 3, 3, 3, 4, 4, 4, 4,
-		1, 1, 1, 1, 2, 2, 2, 2,
-		3, 3, 3, 3, 4, 4, 4, 5,
-	})
-
-	testStartingHeight = uint32(600)
 )
 
 // testContext contains functionality to support client unit tests.

Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,7 @@ func loopIn(ctx *cli.Context) error {`
`41`	`41`	`args = args.Tail()`
`42`	`42`	`default:`
`43`	`43`	`// Show command help if no arguments and flags were provided.`
`44`		`- cli.ShowCommandHelp(ctx, "in")`
`45`		`- return nil`
	`44`	`+ return cli.ShowCommandHelp(ctx, "in")`
`46`	`45`	`}`
`47`	`46`
`48`	`47`	`amt, err := parseAmt(amtStr)`
Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,7 @@ func loopOut(ctx *cli.Context) error {`
`59`	`59`	`args = args.Tail()`
`60`	`60`	`default:`
`61`	`61`	`// Show command help if no arguments and flags were provided.`
`62`		`- cli.ShowCommandHelp(ctx, "out")`
`63`		`- return nil`
	`62`	`+ return cli.ShowCommandHelp(ctx, "out")`
`64`	`63`	`}`
`65`	`64`
`66`	`65`	`amt, err := parseAmt(amtStr)`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ type limits struct {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`func getLimits(amt btcutil.Amount, quote looprpc.QuoteResponse) limits {`
`100`		`- maxSwapRoutingFee := getMaxRoutingFee(btcutil.Amount(amt))`
	`100`	`+ maxSwapRoutingFee := getMaxRoutingFee(amt)`
`101`	`101`	`maxPrepayRoutingFee := getMaxRoutingFee(btcutil.Amount(`
`102`	`102`	`quote.PrepayAmt,`
`103`	`103`	`))`
`@@ -126,7 +126,7 @@ func displayLimits(swapType loop.Type, amt btcutil.Amount, l *limits,`
`126`	`126`	`if l.maxPrepayRoutingFee != nil {`
`127`	`127`	`totalSuccessMax += *l.maxPrepayRoutingFee`
`128`	`128`	`}`
`129`		`-`
	`129`	`+`
`130`	`130`	`if swapType == loop.TypeIn && externalHtlc {`
`131`	`131`	`fmt.Printf("On-chain fee for external loop in is not " +`
`132`	`132`	`"included.\nSufficient fees will need to be paid " +`
`@@ -135,7 +135,7 @@ func displayLimits(swapType loop.Type, amt btcutil.Amount, l *limits,`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`fmt.Printf("Max swap fees for %d Loop %v: %d\n",`
`138`		`- btcutil.Amount(amt), swapType, totalSuccessMax,`
	`138`	`+ amt, swapType, totalSuccessMax,`
`139`	`139`	`)`
`140`	`140`
`141`	`141`	`fmt.Printf("CONTINUE SWAP? (y/n), expand fee detail (x): ")`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ func quote(ctx *cli.Context) error {`
`28`	`28`	`// Show command help if the incorrect number arguments and/or flags were`
`29`	`29`	`// provided.`
`30`	`30`	`if ctx.NArg() != 1 \|\| ctx.NumFlags() > 1 {`
`31`		`- cli.ShowCommandHelp(ctx, "quote")`
`32`		`- return nil`
	`31`	`+ return cli.ShowCommandHelp(ctx, "quote")`
`33`	`32`	`}`
`34`	`33`
`35`	`34`	`args := ctx.Args()`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,9 @@`
`1`	`1`	`package lndclient`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "github.com/btcsuite/btclog"`
`5`	`4`	`"os"`
	`5`	`+`
	`6`	`+ "github.com/btcsuite/btclog"`
`6`	`7`	`)`
`7`	`8`
`8`	`9`	`// log is a logger that is initialized with no output filters. This`