Merge pull request #404 from guggero/fix-alpn-error

guggero · web-flow · commit 7091b90e95a4 · 2021-07-19T13:55:04.000+02:00
loopd: fix ALPN issue with Python
diff --git a/loopd/config.go b/loopd/config.go
@@ -319,6 +319,7 @@ func getTLSConfig(cfg *Config) (*tls.Config, *credentials.TransportCredentials,
 	}
 
 	tlsCfg := cert.TLSConfFromCert(certData)
+	tlsCfg.NextProtos = []string{"h2"}
 	restCreds, err := credentials.NewClientTLSFromFile(
 		cfg.TLSCertPath, "",
 	)
diff --git a/release_notes.md b/release_notes.md
@@ -19,3 +19,7 @@ This file tracks release notes for the loop client.
 #### Breaking Changes
 
 #### Bug Fixes
+- Certain versions of the Python gRPC library
+  [weren't able to connect](https://github.com/grpc/grpc/issues/23172) to
+  `loopd`'s gRPC interface, getting the `missing selected ALPN property` error.
+  A server side fix was introduced to get rid of that error message.

Original file line number	Diff line number	Diff line change
`@@ -319,6 +319,7 @@ func getTLSConfig(cfg Config) (tls.Config, *credentials.TransportCredentials,`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`tlsCfg := cert.TLSConfFromCert(certData)`
	`322`	`+ tlsCfg.NextProtos = []string{"h2"}`
`322`	`323`	`restCreds, err := credentials.NewClientTLSFromFile(`
`323`	`324`	`cfg.TLSCertPath, "",`
`324`	`325`	`)`