staticaddr: don't lock active deposits across state transition

hieblmi · hieblmi · commit d73bf96f7b5f · 2025-03-21T10:30:41.000+01:00
diff --git a/staticaddr/deposit/manager.go b/staticaddr/deposit/manager.go
@@ -519,9 +519,9 @@ func (m *Manager) TransitionDeposits(ctx context.Context, deposits []*Deposit,
 	}
 
 	m.mu.Lock()
-	defer m.mu.Unlock()
-
 	stateMachines, _ := m.toActiveDeposits(&outpoints)
+	m.mu.Unlock()
+
 	if stateMachines == nil {
 		return fmt.Errorf("deposits not found in active deposits")
 	}

Original file line number	Diff line number	Diff line change
`@@ -519,9 +519,9 @@ func (m Manager) TransitionDeposits(ctx context.Context, deposits []Deposit,`
`519`	`519`	`}`
`520`	`520`
`521`	`521`	`m.mu.Lock()`
`522`		`- defer m.mu.Unlock()`
`523`		`-`
`524`	`522`	`stateMachines, _ := m.toActiveDeposits(&outpoints)`
	`523`	`+ m.mu.Unlock()`
	`524`	`+`
`525`	`525`	`if stateMachines == nil {`
`526`	`526`	`return fmt.Errorf("deposits not found in active deposits")`
`527`	`527`	`}`