sweepbatcher: fix a bug in dest address selection

starius · starius · commit e2fb13432fc0 · 2025-06-12T15:48:44.000-03:00
For presigned possible remaining groups, the destination address of the current
batch was used instead of the destination address of an expected future batch.

TODO: reproduce in unit test "purged". For this, each swap should have a
separate destination address.
diff --git a/sweepbatcher/presigned.go b/sweepbatcher/presigned.go
@@ -246,7 +246,7 @@ func (b *batch) presign(ctx context.Context, newSweeps []*sweep) error {
 
 		// Cache the destination address.
 		destAddr, err := getPresignedSweepsDestAddr(
-			ctx, b.cfg.presignedHelper, b.primarySweepID,
+			ctx, b.cfg.presignedHelper, primarySweepID,
 			b.cfg.chainParams,
 		)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ func (b batch) presign(ctx context.Context, newSweeps []sweep) error {`
`246`	`246`
`247`	`247`	`// Cache the destination address.`
`248`	`248`	`destAddr, err := getPresignedSweepsDestAddr(`
`249`		`- ctx, b.cfg.presignedHelper, b.primarySweepID,`
	`249`	`+ ctx, b.cfg.presignedHelper, primarySweepID,`
`250`	`250`	`b.cfg.chainParams,`
`251`	`251`	`)`
`252`	`252`	`if err != nil {`