loop: fix race in loopOutSwap.payInvoiceAsync

The function used to call the method swapKit.swapInfo() which accessed many
fields of the swapKit which may change in parallel by handlePaymentResult called
by executeSwap (payInvoiceAsync is called in a goroutine). The fields are: cost,
state, and update time.

Author: starius

loopout.go

@@ -873,7 +873,7 @@ func (s *loopOutSwap) payInvoiceAsync(ctx context.Context,
 		}
 
 		if err := s.swapKit.server.ReportRoutingResult(
-			ctx, s.swapInfo().SwapHash, s.swapInvoicePaymentAddr,
+			ctx, s.hash, s.swapInvoicePaymentAddr,
 			reportType, paymentSuccess, int32(attempts),
 			dt.Milliseconds(),
 		); err != nil {