staticaddr: don't lock active deposits across state transition

hieblmi · hieblmi · commit f5c543847927 · 2025-03-21T09:39:05.000+01:00
diff --git a/staticaddr/deposit/manager.go b/staticaddr/deposit/manager.go
@@ -532,9 +532,9 @@ func (m *Manager) TransitionDeposits(ctx context.Context, deposits []*Deposit,
 	}
 
 	m.mu.Lock()
-	defer m.mu.Unlock()
-
 	stateMachines, _ := m.toActiveDeposits(&outpoints)
+	m.mu.Unlock()
+
 	if stateMachines == nil {
 		return fmt.Errorf("deposits not found in active deposits")
 	}

Original file line number	Diff line number	Diff line change
`@@ -532,9 +532,9 @@ func (m Manager) TransitionDeposits(ctx context.Context, deposits []Deposit,`
`532`	`532`	`}`
`533`	`533`
`534`	`534`	`m.mu.Lock()`
`535`		`- defer m.mu.Unlock()`
`536`		`-`
`537`	`535`	`stateMachines, _ := m.toActiveDeposits(&outpoints)`
	`536`	`+ m.mu.Unlock()`
	`537`	`+`
`538`	`538`	`if stateMachines == nil {`
`539`	`539`	`return fmt.Errorf("deposits not found in active deposits")`
`540`	`540`	`}`