loop: add resume manager #1029
loop: add resume manager #1029
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a recovery manager to handle unfinished swaps due to routing failures. It adds a NotificationManager interface and a resumeManager struct to manage and recover unfinished swaps. The changes include modifications to client.go, loopd/daemon.go, loopout.go, notifications/manager.go, and swapserverrpc/server.proto to incorporate the new recovery mechanism. The review focuses on identifying potential issues related to correctness, efficiency, and maintainability, with a severity level of medium or higher.
| message SubscribeNotificationsRequest { | ||
| enum ListenerVersion { | ||
| LEGACY = 0; | ||
| V1 = 1; | ||
| } | ||
|
|
||
| ListenerVersion version = 1; | ||
| } |
There was a problem hiding this comment.
medium: Adding a ListenerVersion enum and version field to the SubscribeNotificationsRequest message. It's good practice to add a comment explaining the purpose of this versioning and when new versions might be introduced. This will help future developers understand the intent and maintain the code more effectively.
bhandras
force-pushed
the
resume-stuck-swaps
branch
from
11bffcb to
7706173
Compare
bhandras
force-pushed
the
resume-stuck-swaps
branch
from
7706173 to
5cffa6e
Compare
bhandras
force-pushed
the
resume-stuck-swaps
branch
from
3dda018 to
c93f1ab
Compare
sputn1ck
force-pushed
the
resume-stuck-swaps
branch
from
c93f1ab to
c411679
Compare
sputn1ck
force-pushed
the
resume-stuck-swaps
branch
from
c411679 to
79af5b3
Compare
3 participants
This PR enables resumption of a stuck swap due to routing failures.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes