multi: fix race conditions and run unit tests with -race #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
unit-race
branch
5 times, most recently
from
d38ac11 to
c69d9e4
Compare
starius
changed the title
bhandras
approved these changes
Mar 13, 2025
| select { | ||
| case currentHeight := <-newBlockChan: | ||
| m.currentHeight = currentHeight | ||
| m.currentHeight.Store(currentHeight) |
Member
There was a problem hiding this comment.
I think we should also initialize the current height by querying best height at the start on Run.
Collaborator
Author
There was a problem hiding this comment.
Run already does this as soon as possible. Actually this is the only thing Run does - keeping currentHeight up-to-date.
staticaddr/address/manager.go
Outdated
|
|
||
| // Ensure that we have that we have a sane current block height. | ||
| if m.currentHeight == 0 { | ||
| if m.currentHeight.Load() == 0 { |
Member
There was a problem hiding this comment.
This check could be removed if current height is correctly initialized.
Collaborator
Author
There was a problem hiding this comment.
Run runs in background, so the caller doesn't know when Run has initialized currentHeight.
Additionally, it is better to double check even if it was initialized before, to detect a wrong order of methods called.
starius
force-pushed
the
unit-race
branch
3 times, most recently
from
a123bc5 to
257b3db
Compare
bhandras
approved these changes
Mar 17, 2025
| // NewManager creates a new address manager. | ||
| func NewManager(cfg *ManagerConfig) *Manager { | ||
| return &Manager{ | ||
| func NewManager(cfg *ManagerConfig, currentHeight int32) *Manager { |
Collaborator
Author
|
Rebased |
github.com/coreos/bbolt has race conditions: golang/go#54690
Make the current height an atomic variable in staticaddr/address/manager.go and in staticaddr/withdraw/manager.go. Removed the initiation height from staticaddr/deposit/manager.go (not needed).
The function used to call the method swapKit.swapInfo() which accessed many fields of the swapKit which may change in parallel by handlePaymentResult called by executeSwap (payInvoiceAsync is called in a goroutine). The fields are: cost, state, and update time.
If Run sets the current height field, it is technically a race between Run and other methods reading the field. Setting in New is a safer option. Removed a check that height is not 0 from static address manager.
hieblmi
force-pushed
the
unit-race
branch
14 times, most recently
from
7cc50fe to
2f2c5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes