Skip to content

staticaddr: allow rbf'ing withdrawal transactions #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

staticaddr: allow rbf'ing withdrawal transactions #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82e34a6
staticaddr: allow rbf'ing withdrawal transactions
hieblmi Mar 19, 2025
ff44b3b
staticaddr: log deposit state transition only if executed
hieblmi Mar 21, 2025
b5af507
staticaddr: don't ignore output-already-spent publish error
hieblmi Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions staticaddr/deposit/fsm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,9 @@ func (f *FSM) DepositStatesV0() fsm.States {
Withdrawing: fsm.State{
Transitions: fsm.Transitions{
OnWithdrawn: Withdrawn,
// OnWithdrawInitiated is sent if a fee bump was
// requested and the withdrawal was republished.
OnWithdrawInitiated: Withdrawing,
// Upon recovery, we go back to the Deposited
// state. The deposit by then has a withdrawal
// address stamped to it which will cause it to
Expand Down Expand Up @@ -358,7 +361,8 @@ func (f *FSM) DepositStatesV0() fsm.States {
},
Withdrawn: fsm.State{
Transitions: fsm.Transitions{
OnExpiry: Expired,
OnExpiry: Expired,
OnWithdrawn: Withdrawn,
},
Action: f.FinalizeDepositAction,
},
Expand All @@ -374,11 +378,6 @@ func (f *FSM) updateDeposit(ctx context.Context,
return
}

f.Debugf("NextState: %v, PreviousState: %v, Event: %v",
notification.NextState, notification.PreviousState,
notification.Event,
)

type checkStateFunc func(state fsm.StateType) bool
type setStateFunc func(state fsm.StateType)
checkFunc := checkStateFunc(f.deposit.IsInState)
Expand All @@ -393,6 +392,11 @@ func (f *FSM) updateDeposit(ctx context.Context,
return
}

f.Debugf("NextState: %v, PreviousState: %v, Event: %v",
notification.NextState, notification.PreviousState,
notification.Event,
)

err := f.cfg.Store.UpdateDeposit(ctx, f.deposit)
if err != nil {
f.Errorf("unable to update deposit: %w", err)
Expand Down
Loading