Skip to content

loopin: use context.WithoutCancel in cleanup #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

loopin: use context.WithoutCancel in cleanup #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion staticaddr/loopin/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ func (f *FSM) cleanUpSessions(ctx context.Context,
sessions []*input.MuSig2SessionInfo) {

for _, s := range sessions {
err := f.cfg.Signer.MuSig2Cleanup(ctx, s.SessionID)
err := f.cfg.Signer.MuSig2Cleanup(
context.WithoutCancel(ctx), s.SessionID,
Copy link
Collaborator

@hieblmi hieblmi Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice subtle catch

)
if err != nil {
f.Warnf("unable to cleanup musig2 session: %v", err)
}
Expand Down
3 changes: 2 additions & 1 deletion staticaddr/loopin/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,8 @@ func (m *Manager) handleLoopInSweepReq(ctx context.Context,
// We'll clean up the session if we don't get to signing.
defer func() {
err = m.cfg.Signer.MuSig2Cleanup(
ctx, musig2Session.SessionID,
context.WithoutCancel(ctx),
musig2Session.SessionID,
)
if err != nil {
log.Errorf("Error cleaning up musig2 session: "+
Expand Down