tapfreighter: rename ChainPorter state to SendStateStorePostAnchorTxConf

This commit renames the ChainPorter state from SendStateStoreProofs to
SendStateStorePostAnchorTxConf. The new name more accurately represents
its function, reflecting that this state now performs broader storage
updates beyond just storing proofs. Additionally, the name indicates
that this state is triggered after the confirmation of the transfer
anchoring transaction on-chain, without delving into the specific
details of the operations performed within the state.

Author: ffranr

tapfreighter/chain_porter.go

@@ -415,7 +415,7 @@ func (p *ChainPorter) waitForTransferTxConf(pkg *sendPackage) error {
 			confEvent.BlockHash,
 		)
 
-		pkg.SendState = SendStateStoreProofs
+		pkg.SendState = SendStateStorePostAnchorTxConf
 
 	case err := <-errChan:
 		return fmt.Errorf("error whilst waiting for package tx "+
@@ -1233,9 +1233,10 @@ func (p *ChainPorter) stateStep(currentPkg sendPackage) (*sendPackage, error) {
 		err := p.waitForTransferTxConf(&currentPkg)
 		return &currentPkg, err
 
-	// At this point, the transfer transaction is confirmed on-chain. We go
-	// on to store the sender and receiver proofs in the proof archive.
-	case SendStateStoreProofs:
+	// The transfer transaction is now confirmed on-chain. We'll update the
+	// package state on disk to reflect this. This step frees up the change
+	// outputs so that they can be used in future transactions.
+	case SendStateStorePostAnchorTxConf:
 		err := p.storeProofs(&currentPkg)
 		if err != nil {
 			return nil, fmt.Errorf("unable to store proofs: %w",

tapfreighter/parcel.go

@@ -51,9 +51,12 @@ const (
 	// transaction to confirm on-chain.
 	SendStateWaitTxConf
 
-	// SendStateStoreProofs is the state in which we will write the sender
-	// and receiver proofs to the proof archive.
-	SendStateStoreProofs
+	// SendStateStorePostAnchorTxConf is the state in which we will update
+	// the send package in store to reflect the confirmation of the anchor
+	// transaction. This includes:
+	// * writing the sender and receiver proofs to the proof archive
+	// * marking the transfer change outputs as spendable.
+	SendStateStorePostAnchorTxConf
 
 	// SendStateTransferProofs is the state where we attempt to transfer
 	// on-chain transaction proof(s) to the receiving party or parties.
@@ -85,8 +88,8 @@ func (s SendState) String() string {
 	case SendStateWaitTxConf:
 		return "SendStateWaitTxConf"
 
-	case SendStateStoreProofs:
-		return "SendStateStoreProofs"
+	case SendStateStorePostAnchorTxConf:
+		return "SendStateStorePostAnchorTxConf"
 
 	case SendStateTransferProofs:
 		return "SendStateTransferProofs"