Skip to content

Commit 1111c6a

Browse files
committed
authmailboxrpc: clarify comments on message filtering
1 parent bb41b6f commit 1111c6a

File tree

3 files changed

+56
-7
lines changed

3 files changed

+56
-7
lines changed

taprpc/authmailboxrpc/mailbox.pb.go

Lines changed: 24 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

taprpc/authmailboxrpc/mailbox.proto

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,33 @@ message ReceiveMessagesRequest {
165165

166166
// Carries the initial parameters from the client to start receiving messages.
167167
message InitReceive {
168+
// The public key identifier of the receiver of the messages that should be
169+
// received through a message receive stream, encoded as the raw bytes of
170+
// the compressed public key.
168171
bytes receiver_id = 1;
172+
173+
// The exclusive start message ID, meaning messages with this ID or higher
174+
// will be included in the response. This allows the client to resume
175+
// receiving messages from a specific point without missing any. One of
176+
// start_message_id_exclusive, start_block_height_inclusive or
177+
// start_timestamp_exclusive must be at their non-default values for any
178+
// existing messages to be returned!
169179
uint64 start_message_id_exclusive = 2;
180+
181+
// The inclusive start block height, meaning messages from this block height
182+
// or higher will be included in the response. This allows the client to
183+
// filter messages based on the block height at which they were produced.
184+
// One of start_message_id_exclusive, start_block_height_inclusive or
185+
// start_timestamp_exclusive must be at their non-default values for any
186+
// existing messages to be returned!
170187
uint32 start_block_height_inclusive = 3;
188+
189+
// The exclusive start timestamp in Unix epoch seconds, meaning messages
190+
// with a timestamp strictly greater than this value will be included in the
191+
// response. This allows the client to filter messages based on their
192+
// arrival time at the server. One of start_message_id_exclusive,
193+
// start_block_height_inclusive or start_timestamp_exclusive must be at
194+
// their non-default values for any existing messages to be returned!
171195
int64 start_timestamp_exclusive = 4;
172196
}
173197

taprpc/authmailboxrpc/mailbox.swagger.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,19 +187,23 @@
187187
"properties": {
188188
"receiver_id": {
189189
"type": "string",
190-
"format": "byte"
190+
"format": "byte",
191+
"description": "The public key identifier of the receiver of the messages that should be\nreceived through a message receive stream, encoded as the raw bytes of\nthe compressed public key."
191192
},
192193
"start_message_id_exclusive": {
193194
"type": "string",
194-
"format": "uint64"
195+
"format": "uint64",
196+
"title": "The exclusive start message ID, meaning messages with this ID or higher\nwill be included in the response. This allows the client to resume\nreceiving messages from a specific point without missing any. One of\nstart_message_id_exclusive, start_block_height_inclusive or\nstart_timestamp_exclusive must be at their non-default values for any\nexisting messages to be returned!"
195197
},
196198
"start_block_height_inclusive": {
197199
"type": "integer",
198-
"format": "int64"
200+
"format": "int64",
201+
"title": "The inclusive start block height, meaning messages from this block height\nor higher will be included in the response. This allows the client to\nfilter messages based on the block height at which they were produced.\nOne of start_message_id_exclusive, start_block_height_inclusive or\nstart_timestamp_exclusive must be at their non-default values for any\nexisting messages to be returned!"
199202
},
200203
"start_timestamp_exclusive": {
201204
"type": "string",
202-
"format": "int64"
205+
"format": "int64",
206+
"title": "The exclusive start timestamp in Unix epoch seconds, meaning messages\nwith a timestamp strictly greater than this value will be included in the\nresponse. This allows the client to filter messages based on their\narrival time at the server. One of start_message_id_exclusive,\nstart_block_height_inclusive or start_timestamp_exclusive must be at\ntheir non-default values for any existing messages to be returned!"
203207
}
204208
},
205209
"description": "Carries the initial parameters from the client to start receiving messages."

0 commit comments

Comments
 (0)