rpcserver: use specifier to select rfq channels

When querying for channels we now provide the specifier, allowing the
helper methods to check against the specifier with all the helpers that
we introduced in the previous commits. Now a channel with an asset ID
that belongs to a group, may qualify as valid "balance" of that group.

Author: GeorgeTsagk

rpcserver.go

@@ -6685,16 +6685,10 @@ func (r *rpcServer) checkPeerChannel(ctx context.Context, peer route.Vertex,
 	// For any other case, we'll want to make sure there is a channel with
 	// a non-zero balance of the given asset to carry the order.
 	default:
-		assetID, err := specifier.UnwrapIdOrErr()
-		if err != nil {
-			return fmt.Errorf("cannot check asset channel, " +
-				"missing asset ID")
-		}
-
 		// If we don't get an error here, it means we do have an asset
 		// channel with the peer. The intention doesn't matter as we're
 		// just checking whether a channel exists.
-		_, err = r.rfqChannel(ctx, assetID, &peer, NoIntention)
+		_, err := r.rfqChannel(ctx, specifier, &peer, NoIntention)
 		if err != nil {
 			return fmt.Errorf("error checking asset channel: %w",
 				err)
@@ -7370,9 +7364,11 @@ func (r *rpcServer) SendPayment(req *tchrpc.SendPaymentRequest,
 			peerPubKey = &parsedKey
 		}
 
+		specifier := asset.NewSpecifierFromId(assetID)
+
 		// We can now query the asset channels we have.
 		assetChan, err := r.rfqChannel(
-			ctx, assetID, peerPubKey, SendIntention,
+			ctx, specifier, peerPubKey, SendIntention,
 		)
 		if err != nil {
 			return fmt.Errorf("error finding asset channel to "+
@@ -7663,9 +7659,11 @@ func (r *rpcServer) AddInvoice(ctx context.Context,
 		peerPubKey = &parsedKey
 	}
 
+	specifier := asset.NewSpecifierFromId(assetID)
+
 	// We can now query the asset channels we have.
 	assetChan, err := r.rfqChannel(
-		ctx, assetID, peerPubKey, ReceiveIntention,
+		ctx, specifier, peerPubKey, ReceiveIntention,
 	)
 	if err != nil {
 		return nil, fmt.Errorf("error finding asset channel to use: %w",
@@ -7952,60 +7950,59 @@ const (
 
 // rfqChannel returns the channel to use for RFQ operations. If a peer public
 // key is specified, the channels are filtered by that peer. If there are
-// multiple channels for the same asset, the user must specify the peer public
-// key.
-func (r *rpcServer) rfqChannel(ctx context.Context, id asset.ID,
+// multiple channels for the same specifier, the user must specify the peer
+// public key.
+func (r *rpcServer) rfqChannel(ctx context.Context, specifier asset.Specifier,
 	peerPubKey *route.Vertex,
-	intention chanIntention) (*channelWithAsset, error) {
+	intention chanIntention) (*channelWithSpecifier, error) {
 
-	balances, err := r.computeChannelAssetBalance(ctx)
+	balances, err := r.computeChannelAssetBalance(ctx, specifier)
 	if err != nil {
 		return nil, fmt.Errorf("error computing available asset "+
 			"channel balance: %w", err)
 	}
 
-	assetBalances, haveBalance := balances[id]
-	if !haveBalance || len(assetBalances) == 0 {
-		return nil, fmt.Errorf("no asset channel balance found for "+
-			"asset %s", id.String())
+	if len(balances) == 0 {
+		return nil, fmt.Errorf("no asset channel balance found for %s",
+			&specifier)
 	}
 
 	// If a peer public key was specified, we always want to use that to
 	// filter the asset channels.
 	if peerPubKey != nil {
-		assetBalances = fn.Filter(
-			assetBalances, func(c channelWithAsset) bool {
+		balances = fn.Filter(
+			balances, func(c channelWithSpecifier) bool {
 				return c.channelInfo.PubKeyBytes == *peerPubKey
 			},
 		)
 	}
 
 	switch {
-	// If there are multiple asset channels for the same asset, we need to
-	// ask the user to specify the peer public key. Otherwise, we don't know
-	// who to ask for a quote.
-	case len(assetBalances) > 1 && peerPubKey == nil:
+	// If there are multiple asset channels for the same specifier, we need
+	// to ask the user to specify the peer public key. Otherwise, we don't
+	// know who to ask for a quote.
+	case len(balances) > 1 && peerPubKey == nil:
 		return nil, fmt.Errorf("multiple asset channels found for "+
-			"asset %s, please specify the peer pubkey", id.String())
+			"%s, please specify the peer pubkey", &specifier)
 
 	// We don't have any channels with that asset ID and peer.
-	case len(assetBalances) == 0:
-		return nil, fmt.Errorf("no asset channel found for asset %s "+
-			"and peer %s", id.String(), peerPubKey.String())
+	case len(balances) == 0:
+		return nil, fmt.Errorf("no asset channel found for %s",
+			&specifier)
 	}
 
 	// If the user specified a peer public key, and we still have multiple
 	// channels, it means we have multiple channels with the same asset and
 	// the same peer, as we ruled out the rest of the cases above.
 
 	// Initialize best balance to first channel of the list.
-	bestBalance := assetBalances[0]
+	bestBalance := balances[0]
 
 	switch intention {
 	case ReceiveIntention:
 		// If the intention is to receive, return the channel
 		// with the best remote balance.
-		fn.ForEach(assetBalances, func(b channelWithAsset) {
+		fn.ForEach(balances, func(b channelWithSpecifier) {
 			if b.assetInfo.RemoteBalance >
 				bestBalance.assetInfo.RemoteBalance {
 
@@ -8016,7 +8013,7 @@ func (r *rpcServer) rfqChannel(ctx context.Context, id asset.ID,
 	case SendIntention:
 		// If the intention is to send, return the channel with
 		// the best local balance.
-		fn.ForEach(assetBalances, func(b channelWithAsset) {
+		fn.ForEach(balances, func(b channelWithSpecifier) {
 			if b.assetInfo.LocalBalance >
 				bestBalance.assetInfo.LocalBalance {
 
@@ -8032,28 +8029,33 @@ func (r *rpcServer) rfqChannel(ctx context.Context, id asset.ID,
 	return &bestBalance, nil
 }
 
-// channelWithAsset is a helper struct that combines the information of a single
-// asset within a channel with the channels' general information.
-type channelWithAsset struct {
-	// assetInfo is the information about one of the assets in a channel.
-	assetInfo rfqmsg.JsonAssetChanInfo
+// channelWithSpecifier is a helper struct that combines the information of an
+// asset specifier that is satisfied by a channel with the channels' general
+// information.
+type channelWithSpecifier struct {
+	// specifier is the asset specifier that is satisfied by this channels'
+	// assets.
+	specifier asset.Specifier
 
 	// channelInfo is the information about the channel the asset is
 	// committed to.
 	channelInfo lndclient.ChannelInfo
+
+	// assetInfo contains the asset related info of the channel.
+	assetInfo rfqmsg.JsonAssetChanInfo
 }
 
 // computeChannelAssetBalance computes the total local and remote balance for
-// each asset channel.
-func (r *rpcServer) computeChannelAssetBalance(
-	ctx context.Context) (map[asset.ID][]channelWithAsset, error) {
+// each asset channel that matches the provided asset specifier.
+func (r *rpcServer) computeChannelAssetBalance(ctx context.Context,
+	specifier asset.Specifier) ([]channelWithSpecifier, error) {
 
 	activeChannels, err := r.cfg.Lnd.Client.ListChannels(ctx, true, false)
 	if err != nil {
 		return nil, fmt.Errorf("unable to fetch channels: %w", err)
 	}
 
-	channelsByID := make(map[asset.ID][]channelWithAsset)
+	channels := make([]channelWithSpecifier, 0)
 	for chanIdx := range activeChannels {
 		openChan := activeChannels[chanIdx]
 		if len(openChan.CustomChannelData) == 0 {
@@ -8067,27 +8069,37 @@ func (r *rpcServer) computeChannelAssetBalance(
 				"data: %w", err)
 		}
 
-		for assetIdx := range assetData.Assets {
-			assetOutput := assetData.Assets[assetIdx]
-			assetIDStr := assetOutput.AssetInfo.AssetGenesis.AssetID
-			assetIDBytes, err := hex.DecodeString(assetIDStr)
-			if err != nil {
-				return nil, fmt.Errorf("error decoding asset "+
-					"ID: %w", err)
+		// Check if the assets of this channel match the provided
+		// specifier.
+		pass, err := r.cfg.RfqManager.ChannelCompatible(
+			ctx, assetData.Assets, specifier,
+		)
+		if err != nil {
+			return nil, err
+		}
+
+		if pass {
+			// Since the assets of the channel passed the above
+			// filter, we're safe to aggregate their info to be
+			// represented as a single entity.
+			var aggrInfo rfqmsg.JsonAssetChanInfo
+
+			// TODO(george): refactor when JSON gets fixed
+			for _, info := range assetData.Assets {
+				aggrInfo.Capacity += info.Capacity
+				aggrInfo.LocalBalance += info.LocalBalance
+				aggrInfo.RemoteBalance += info.RemoteBalance
 			}
-			var assetID asset.ID
-			copy(assetID[:], assetIDBytes)
 
-			channelsByID[assetID] = append(
-				channelsByID[assetID], channelWithAsset{
-					assetInfo:   assetOutput,
-					channelInfo: openChan,
-				},
-			)
+			channels = append(channels, channelWithSpecifier{
+				specifier:   specifier,
+				channelInfo: openChan,
+				assetInfo:   aggrInfo,
+			})
 		}
 	}
 
-	return channelsByID, nil
+	return channels, nil
 }
 
 // getInboundPolicy returns the policy of the given channel that points towards