multi: add flag plumbing for skipping proof courier ping check

Adds support for setting a flag to skip the preliminary proof courier
ping check in the asset send process. The flag can be set via both
the command line and RPC.

This commit only adds the plumbing to populate the flag; it does not
yet read or act on its value.

Author: ffranr

cmd/commands/assets.go

@@ -38,31 +38,32 @@ var assetsCommands = []cli.Command{
 }
 
 var (
-	assetTypeName                = "type"
-	assetTagName                 = "name"
-	assetSupplyName              = "supply"
-	assetMetaBytesName           = "meta_bytes"
-	assetMetaFilePathName        = "meta_file_path"
-	assetMetaTypeName            = "meta_type"
-	assetDecimalDisplayName      = "decimal_display"
-	assetNewGroupedAssetName     = "new_grouped_asset"
-	assetGroupedAssetName        = "grouped_asset"
-	assetShowWitnessName         = "show_witness"
-	assetShowSpentName           = "show_spent"
-	assetShowLeasedName          = "show_leased"
-	assetIncludeLeasedName       = "include_leased"
-	assetShowUnconfMintsName     = "show_unconfirmed_mints"
-	assetGroupKeyName            = "group_key"
-	assetGroupAnchorName         = "group_anchor"
-	anchorTxidName               = "anchor_txid"
-	batchKeyName                 = "batch_key"
-	groupByGroupName             = "by_group"
-	assetIDName                  = "asset_id"
-	shortResponseName            = "short"
-	universeCommitmentsName      = "universe_commitments"
-	feeRateName                  = "sat_per_vbyte"
-	assetAmountName              = "amount"
-	burnOverrideConfirmationName = "override_confirmation_destroy_assets"
+	assetTypeName                 = "type"
+	assetTagName                  = "name"
+	assetSupplyName               = "supply"
+	assetMetaBytesName            = "meta_bytes"
+	assetMetaFilePathName         = "meta_file_path"
+	assetMetaTypeName             = "meta_type"
+	assetDecimalDisplayName       = "decimal_display"
+	assetNewGroupedAssetName      = "new_grouped_asset"
+	assetGroupedAssetName         = "grouped_asset"
+	assetShowWitnessName          = "show_witness"
+	assetShowSpentName            = "show_spent"
+	assetShowLeasedName           = "show_leased"
+	assetIncludeLeasedName        = "include_leased"
+	assetShowUnconfMintsName      = "show_unconfirmed_mints"
+	assetGroupKeyName             = "group_key"
+	assetGroupAnchorName          = "group_anchor"
+	anchorTxidName                = "anchor_txid"
+	batchKeyName                  = "batch_key"
+	groupByGroupName              = "by_group"
+	assetIDName                   = "asset_id"
+	shortResponseName             = "short"
+	universeCommitmentsName       = "universe_commitments"
+	feeRateName                   = "sat_per_vbyte"
+	skipProofCourierPingCheckName = "skip-proof-courier-ping-check"
+	assetAmountName               = "amount"
+	burnOverrideConfirmationName  = "override_confirmation_destroy_assets"
 )
 
 var mintAssetCommand = cli.Command{
@@ -824,6 +825,10 @@ var sendAssetsCommand = cli.Command{
 			Usage: "if set, the fee rate in sat/vB to use for " +
 				"the anchor transaction",
 		},
+		cli.BoolFlag{
+			Name:  skipProofCourierPingCheckName,
+			Usage: "if set, skip the proof courier ping check",
+		},
 		// TODO(roasbeef): add arg for file name to write sender proof
 		// blob
 	},
@@ -848,6 +853,9 @@ func sendAssets(ctx *cli.Context) error {
 	resp, err := client.SendAsset(ctxc, &taprpc.SendAssetRequest{
 		TapAddrs: addrs,
 		FeeRate:  feeRate,
+		SkipProofCourierPingCheck: ctx.Bool(
+			skipProofCourierPingCheckName,
+		),
 	})
 	if err != nil {
 		return fmt.Errorf("unable to send assets: %w", err)

rpcserver.go

@@ -3375,7 +3375,10 @@ func (r *rpcServer) SendAsset(ctx context.Context,
 	}
 
 	resp, err := r.cfg.ChainPorter.RequestShipment(
-		tapfreighter.NewAddressParcel(feeRate, req.Label, tapAddrs...),
+		tapfreighter.NewAddressParcel(
+			feeRate, req.Label, req.SkipProofCourierPingCheck,
+			tapAddrs...,
+		),
 	)
 	if err != nil {
 		return nil, err

tapfreighter/parcel.go

@@ -140,6 +140,12 @@ type AddressParcel struct {
 
 	// label is an optional user provided transfer label.
 	label string
+
+	// skipProofCourierPingCheck bool is a flag that indicates whether the
+	// proof courier ping check should be skipped. This is useful for
+	// testing purposes or to force transfer attempts even if the
+	// proof courier is not immediately reachable.
+	skipProofCourierPingCheck bool
 }
 
 // A compile-time assertion to ensure AddressParcel implements the parcel
@@ -148,16 +154,18 @@ var _ Parcel = (*AddressParcel)(nil)
 
 // NewAddressParcel creates a new AddressParcel.
 func NewAddressParcel(feeRate *chainfee.SatPerKWeight, label string,
+	skipProofCourierPingCheck bool,
 	destAddrs ...*address.Tap) *AddressParcel {
 
 	return &AddressParcel{
 		parcelKit: &parcelKit{
 			respChan: make(chan *OutboundParcel, 1),
 			errChan:  make(chan error, 1),
 		},
-		destAddrs:       destAddrs,
-		transferFeeRate: feeRate,
-		label:           label,
+		destAddrs:                 destAddrs,
+		transferFeeRate:           feeRate,
+		label:                     label,
+		skipProofCourierPingCheck: skipProofCourierPingCheck,
 	}
 }
 
@@ -168,8 +176,9 @@ func (p *AddressParcel) pkg() *sendPackage {
 
 	// Initialize a package with the destination address.
 	return &sendPackage{
-		Parcel: p,
-		Label:  p.label,
+		Parcel:                    p,
+		Label:                     p.label,
+		SkipProofCourierPingCheck: p.skipProofCourierPingCheck,
 	}
 }
 
@@ -483,6 +492,12 @@ type sendPackage struct {
 	// Note is a user provided description for this transfer. This is
 	// currently only used by asset burn transfers.
 	Note string
+
+	// SkipProofCourierPingCheck bool is a flag that indicates whether the
+	// proof courier ping check should be skipped. This is useful for
+	// testing purposes or to force transfer attempts even if the
+	// proof courier is not immediately reachable.
+	SkipProofCourierPingCheck bool
 }
 
 // ConvertToTransfer prepares the finished send data for storing to the database