Merge pull request #1422 from lightninglabs/lnd-19

Update lnd compile-time dependency to v0.19

Author: guggero

.github/actions/setup-go/action.yml

@@ -19,9 +19,9 @@ env:
   # go needs absolute directories, using the $HOME variable doesn't work here.
   GOPATH: /home/runner/work/go
 
-  GO_VERSION: '1.22.12'
+  GO_VERSION: '1.23.6'
 
-  LITD_ITEST_BRANCH: 'master'
+  LITD_ITEST_BRANCH: 'lnd-19'
 
 jobs:
   #######################
@@ -32,10 +32,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: docker image cache
         uses: jpribyl/[email protected]
@@ -49,10 +51,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: Generate RPC stubs and check REST annotations
         run: make rpc-check
@@ -62,10 +66,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v3
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: Run go mod tidy
         run: make mod-check
@@ -75,10 +81,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: Run test vector creation check
         run: make test-vector-check
@@ -88,7 +96,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Run migration check
         run: make migration-check
@@ -101,10 +109,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: compile code
         run: go install -v ./...
@@ -120,10 +130,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: check default values in sample-tapd.conf file
         run: make sample-conf-check
@@ -136,7 +148,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
@@ -163,10 +175,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: setup go ${{ env.GO_VERSION }}
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: build release for all architectures
         run: make release
@@ -179,12 +193,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: run lint
         run: make lint
@@ -197,10 +213,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: run format
         run: make fmt
@@ -221,21 +239,24 @@ jobs:
           - unit dbbackend=postgres
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: run ${{ matrix.unit_type }}
         run: make ${{ matrix.unit_type }}
 
       - name: Send coverage
-        uses: shogo82148/actions-goveralls@v1
+        uses: coverallsapp/github-action@v2
         if: matrix.unit_type == 'unit-cover'
         continue-on-error: true
         with:
-          path-to-profile: coverage.txt
+          file: coverage.txt
           flag-name: 'unit'
+          format: 'golang'
           parallel: true
 
   ########################
@@ -246,10 +267,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: run itest
         run: make itest cover=1
@@ -267,12 +290,13 @@ jobs:
           retention-days: 5
 
       - name: Send coverage
-        uses: shogo82148/actions-goveralls@v1
+        uses: coverallsapp/github-action@v2
         if: ${{ success() }}
         continue-on-error: true
         with:
-          path-to-profile: itest/coverage.txt
+          file: itest/coverage.txt
           flag-name: 'itest'
+          format: 'golang'
           parallel: true
 
   ########################
@@ -283,10 +307,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: run itest
         run: make itest dbbackend=postgres cover=1
@@ -304,12 +330,13 @@ jobs:
           retention-days: 5
 
       - name: Send coverage
-        uses: shogo82148/actions-goveralls@v1
+        uses: coverallsapp/github-action@v2
         if: ${{ success() }}
         continue-on-error: true
         with:
-          path-to-profile: itest/coverage.txt
+          file: itest/coverage.txt
           flag-name: 'itest'
+          format: 'golang'
           parallel: true
 
   ########################
@@ -321,13 +348,15 @@ jobs:
 
     steps:
       - name: git checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Setup go environment
-        uses: ./.github/actions/setup-go
+      - name: Setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
 
       - name: Clone Lit repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: lightninglabs/lightning-terminal
           ref: ${{ env.LITD_ITEST_BRANCH }}
@@ -365,7 +394,7 @@ jobs:
     needs: [unit-test]
     runs-on: ubuntu-latest
     steps:
-      - uses: shogo82148/actions-goveralls@v1
+      - uses: coverallsapp/github-action@v2
         continue-on-error: true
         with:
           parallel-finished: true

.github/workflows/main.yaml

@@ -10,15 +10,15 @@ defaults:
     shell: bash
 
 env:
-  GO_VERSION: 1.22.12
+  GO_VERSION: 1.23.6
 
 jobs:
   main:
     name: Release build
     runs-on: ubuntu-latest
     steps:
       - name: git checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -38,7 +38,7 @@ jobs:
           fi
 
       - name: setup go ${{ env.GO_VERSION }}
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v5
         with:
           go-version: '${{ env.GO_VERSION }}'
 

.github/workflows/release.yaml

@@ -20,6 +20,8 @@ linters-settings:
     excludes:
       - G402 # Look for bad TLS connection settings.
       - G306 # Poor file permissions used when writing to a new file.
+      - G601 # Implicit memory aliasing in for loop.
+      - G115 # Integer overflow conversion.
   exhaustive:
     default-signifies-exhaustive: true
   gocritic:

.golangci.yml

@@ -1,4 +1,4 @@
-FROM golang:1.22.12-alpine as builder
+FROM golang:1.23.6-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.

Dockerfile

@@ -57,7 +57,7 @@ DOCKER_TOOLS = docker run \
   -v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \
   -v $$(pwd):/build taproot-assets-tools
 
-GO_VERSION = 1.22.12
+GO_VERSION = 1.23.6
 
 GREEN := "\\033[0;32m"
 NC := "\\033[0m"

Makefile

@@ -1,7 +1,7 @@
 package address
 
 import (
-	"github.com/btcsuite/btclog"
+	"github.com/btcsuite/btclog/v2"
 )
 
 // Subsystem defines the logging code for this subsystem.