asset: remove TODO in script key check

Fixes a temporary TODO and makes the check nil-safe.

Author: guggero

asset/asset.go

@@ -1873,16 +1873,27 @@ func (a *Asset) deepEqual(allowSegWitIgnoreTxWitness bool, o *Asset) bool {
 		return false
 	}
 
-	// If both assets have a tweaked key
-	//
-	// TODO(roasbeef): fin
-	if !a.ScriptKey.PubKey.IsEqual(o.ScriptKey.PubKey) {
+	// If both assets have a script public key, comparing that is enough.
+	// We just want to know that we have the same key, not that the internal
+	// representation (e.g. the TweakedKey sub struct being set) is the same
+	// as well.
+	switch {
+	// If only one of the keys is nil, they are not equal.
+	case (a.ScriptKey.PubKey == nil && o.ScriptKey.PubKey != nil) ||
+		(a.ScriptKey.PubKey != nil && o.ScriptKey.PubKey == nil):
+
 		return false
-	}
 
-	/*if !reflect.DeepEqual(a.ScriptKey, o.ScriptKey) {
+	// If both are non-nil, we compare the public keys.
+	case a.ScriptKey.PubKey != nil && o.ScriptKey.PubKey != nil &&
+		!a.ScriptKey.PubKey.IsEqual(o.ScriptKey.PubKey):
+
 		return false
-	}*/
+
+	// If both are nil or both are non-nil and equal, we continue below.
+	default:
+		// Continue below
+	}
 
 	if !a.GroupKey.IsEqual(o.GroupKey) {
 		return false