rpcserver+address: improve logging when generating new tap address

Include the proof courier address in logs when generating a new tap
address. Add a trace-level log for the raw request to aid in debugging.
Also fix a stale comment in the related documentation.

Author: ffranr

address/book.go

@@ -535,7 +535,7 @@ func (b *Book) NewAddress(ctx context.Context, addrVersion Version,
 	error) {
 
 	// Before we proceed and make new keys, make sure that we actually know
-	// of this asset ID, or can import it.
+	// of this asset, or can import it.
 	if _, err := b.QueryAssetInfo(ctx, specifier); err != nil {
 		return nil, fmt.Errorf("unable to make address for unknown "+
 			"asset %s: %w", &specifier, err)

rpcserver.go

@@ -1626,6 +1626,8 @@ func (r *rpcServer) QueryAddrs(ctx context.Context,
 func (r *rpcServer) NewAddr(ctx context.Context,
 	req *taprpc.NewAddrRequest) (*taprpc.Addr, error) {
 
+	rpcsLog.TraceS(ctx, "[NewAddr]: Called", "req", spew.Sdump(req))
+
 	// Parse the proof courier address if one was provided, otherwise use
 	// the default specified in the config.
 	courierAddr := r.cfg.DefaultProofCourierAddr
@@ -1660,9 +1662,6 @@ func (r *rpcServer) NewAddr(ctx context.Context,
 			err)
 	}
 
-	rpcsLog.Infof("[NewAddr]: making new addr: specifier=%s, amt=%v",
-		&specifier, req.Amt)
-
 	err = r.checkBalanceOverflow(ctx, assetID, groupKey, req.Amt)
 	if err != nil {
 		return nil, err
@@ -1695,6 +1694,10 @@ func (r *rpcServer) NewAddr(ctx context.Context,
 		addrVersion = address.V2
 	}
 
+	rpcsLog.Infof("[NewAddr]: Making new addr: specifier=%s, amt=%v, "+
+		"courier=%v, addr_version=%v, asset_version=%v", &specifier,
+		req.Amt, courierAddr, addrVersion, assetVersion)
+
 	// Addresses with version 2 must use the new authmailbox proof courier
 	// type.
 	protocol := courierAddr.Scheme
@@ -1790,8 +1793,8 @@ func (r *rpcServer) NewAddr(ctx context.Context,
 			address.WithAssetVersion(assetVersion),
 		)
 		if err != nil {
-			return nil, fmt.Errorf("unable to make new addr: %w",
-				err)
+			return nil, fmt.Errorf("unable to make new addr with "+
+				"keys: %w", err)
 		}
 	}