itest+rpcserver: check channel balance on keysend

Author: guggero

itest/channels_test.go

@@ -61,7 +61,10 @@ func testChannelRPCs(t *harnessTest) {
 	require.NoError(t.t, err)
 
 	_, err = stream.Recv()
-	require.ErrorContains(t.t, err, "invalid vertex length of 0, want 33")
+	require.ErrorContains(
+		t.t, err, "destination node must be specified for keysend "+
+			"payment",
+	)
 
 	// Now let's also try the invoice path, which should fail because we
 	// don't have any asset channels with peers that we could ask for a

rpcserver.go

@@ -7743,8 +7743,26 @@ func (r *rpcServer) SendPayment(req *tchrpc.SendPaymentRequest,
 				"for keysend payment")
 		}
 
-		var balances []*rfqmsg.AssetBalance
+		if len(req.PaymentRequest.Dest) == 0 {
+			return fmt.Errorf("destination node must be " +
+				"specified for keysend payment")
+		}
+
+		dest, err := route.NewVertexFromBytes(req.PaymentRequest.Dest)
+		if err != nil {
+			return fmt.Errorf("error parsing destination node "+
+				"pubkey: %w", err)
+		}
 
+		// We check that we have the asset amount available in the
+		// channel.
+		_, err = r.rfqChannel(ctx, specifier, &dest, SendIntention)
+		if err != nil {
+			return fmt.Errorf("error finding asset channel to "+
+				"use: %w", err)
+		}
+
+		var balances []*rfqmsg.AssetBalance
 		switch {
 		case specifier.HasId():
 			balances = []*rfqmsg.AssetBalance{