asset: move unit test TestDeriveGroupKey to group_key_test.go

Author: ffranr

asset/asset_test.go

@@ -727,86 +727,6 @@ func TestAssetID(t *testing.T) {
 	require.NotEqual(t, id[:], differentID[:])
 }
 
-// TestDeriveGroupKey tests that group key derivation fails for assets that are
-// not eligible to be group anchors.
-func TestDeriveGroupKey(t *testing.T) {
-	t.Parallel()
-
-	groupPriv := test.RandPrivKey()
-	groupPub := groupPriv.PubKey()
-	groupKeyDesc := test.PubToKeyDesc(groupPub)
-	genSigner := NewMockGenesisSigner(groupPriv)
-	genBuilder := MockGroupTxBuilder{}
-
-	baseGen := RandGenesis(t, Normal)
-	collectGen := RandGenesis(t, Collectible)
-	baseScriptKey := RandScriptKey(t)
-	protoAsset := RandAssetWithValues(t, baseGen, nil, baseScriptKey)
-	nonGenProtoAsset := protoAsset.Copy()
-	nonGenProtoAsset.PrevWitnesses = []Witness{{
-		PrevID: &PrevID{
-			OutPoint: wire.OutPoint{
-				Hash:  hashBytes1,
-				Index: 1,
-			},
-			ID:        hashBytes1,
-			ScriptKey: ToSerialized(pubKey),
-		},
-		TxWitness:       sigWitness,
-		SplitCommitment: nil,
-	}}
-	groupedProtoAsset := protoAsset.Copy()
-	groupedProtoAsset.GroupKey = &GroupKey{
-		GroupPubKey: *groupPub,
-	}
-	groupReq := GroupKeyRequest{
-		RawKey:    groupKeyDesc,
-		AnchorGen: baseGen,
-	}
-
-	// A prototype asset is required for building the genesis virtual TX.
-	_, err := groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "grouped asset cannot be nil")
-
-	// The prototype asset must have a genesis witness.
-	groupReq.NewAsset = nonGenProtoAsset
-	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "asset is not a genesis asset")
-
-	// The prototype asset must not have a group key set.
-	groupReq.NewAsset = groupedProtoAsset
-	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "asset already has group key")
-
-	// The anchor genesis used for signing must have the same asset type
-	// as the prototype asset being signed.
-	groupReq.AnchorGen = collectGen
-	groupReq.NewAsset = protoAsset
-	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "asset group type mismatch")
-
-	// The group key request must include an internal key.
-	groupReq.AnchorGen = baseGen
-	groupReq.RawKey.PubKey = nil
-	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "missing group internal key")
-
-	// The tapscript root in the group key request must be exactly 32 bytes
-	// if present.
-	groupReq.RawKey = groupKeyDesc
-	groupReq.TapscriptRoot = test.RandBytes(33)
-	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.ErrorContains(t, err, "tapscript root must be 32 bytes")
-
-	groupReq.TapscriptRoot = test.RandBytes(32)
-	genTx, err := groupReq.BuildGroupVirtualTx(&genBuilder)
-	require.NoError(t, err)
-
-	groupKey, err := DeriveGroupKey(genSigner, *genTx, groupReq, nil)
-	require.NoError(t, err)
-	require.NotNil(t, groupKey)
-}
-
 // TestAssetWitnesses tests that the asset group witness can be serialized and
 // parsed correctly, and that signature detection works correctly.
 func TestAssetWitnesses(t *testing.T) {

asset/group_key_test.go

@@ -597,3 +597,83 @@ func TestDeriveGroupKeyV0(t *testing.T) {
 	_, err = GroupPubKeyV0(groupPub, groupTweak[:], badTweak)
 	require.Error(t, err)
 }
+
+// TestDeriveGroupKey tests that group key derivation fails for assets that are
+// not eligible to be group anchors.
+func TestDeriveGroupKey(t *testing.T) {
+	t.Parallel()
+
+	groupPriv := test.RandPrivKey()
+	groupPub := groupPriv.PubKey()
+	groupKeyDesc := test.PubToKeyDesc(groupPub)
+	genSigner := NewMockGenesisSigner(groupPriv)
+	genBuilder := MockGroupTxBuilder{}
+
+	baseGen := RandGenesis(t, Normal)
+	collectGen := RandGenesis(t, Collectible)
+	baseScriptKey := RandScriptKey(t)
+	protoAsset := RandAssetWithValues(t, baseGen, nil, baseScriptKey)
+	nonGenProtoAsset := protoAsset.Copy()
+	nonGenProtoAsset.PrevWitnesses = []Witness{{
+		PrevID: &PrevID{
+			OutPoint: wire.OutPoint{
+				Hash:  hashBytes1,
+				Index: 1,
+			},
+			ID:        hashBytes1,
+			ScriptKey: ToSerialized(pubKey),
+		},
+		TxWitness:       sigWitness,
+		SplitCommitment: nil,
+	}}
+	groupedProtoAsset := protoAsset.Copy()
+	groupedProtoAsset.GroupKey = &GroupKey{
+		GroupPubKey: *groupPub,
+	}
+	groupReq := GroupKeyRequest{
+		RawKey:    groupKeyDesc,
+		AnchorGen: baseGen,
+	}
+
+	// A prototype asset is required for building the genesis virtual TX.
+	_, err := groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "grouped asset cannot be nil")
+
+	// The prototype asset must have a genesis witness.
+	groupReq.NewAsset = nonGenProtoAsset
+	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "asset is not a genesis asset")
+
+	// The prototype asset must not have a group key set.
+	groupReq.NewAsset = groupedProtoAsset
+	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "asset already has group key")
+
+	// The anchor genesis used for signing must have the same asset type
+	// as the prototype asset being signed.
+	groupReq.AnchorGen = collectGen
+	groupReq.NewAsset = protoAsset
+	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "asset group type mismatch")
+
+	// The group key request must include an internal key.
+	groupReq.AnchorGen = baseGen
+	groupReq.RawKey.PubKey = nil
+	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "missing group internal key")
+
+	// The tapscript root in the group key request must be exactly 32 bytes
+	// if present.
+	groupReq.RawKey = groupKeyDesc
+	groupReq.TapscriptRoot = test.RandBytes(33)
+	_, err = groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.ErrorContains(t, err, "tapscript root must be 32 bytes")
+
+	groupReq.TapscriptRoot = test.RandBytes(32)
+	genTx, err := groupReq.BuildGroupVirtualTx(&genBuilder)
+	require.NoError(t, err)
+
+	groupKey, err := DeriveGroupKey(genSigner, *genTx, groupReq, nil)
+	require.NoError(t, err)
+	require.NotNil(t, groupKey)
+}