tapdb+tapgarden: refactor RandSeedlingMintingBatch

Refactor RandSeedlingMintingBatch for generalization:
- Rename to RandMintingBatch.
- Change argument to `options...` pattern for extendability.

The next commit will introduce additional options, enabling the
creation of more specific mint batches.

Author: ffranr

tapdb/asset_minting_test.go

@@ -499,7 +499,9 @@ func TestCommitMintingBatchSeedlings(t *testing.T) {
 	// First, we'll write a new minting batch to disk, including an
 	// internal key and a set of seedlings. One random seedling will
 	// be a reissuance into a specific group.
-	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, numSeedlings)
+	mintingBatch := tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(numSeedlings),
+	)
 	_, randGroup, _ := addRandGroupToBatch(
 		t, assetStore, ctx, mintingBatch.Seedlings,
 	)
@@ -600,7 +602,9 @@ func TestCommitMintingBatchSeedlings(t *testing.T) {
 
 	// Insert another normal batch into the database. We should get this
 	// batch back if we query for the set of non-final batches.
-	mintingBatch = tapgarden.RandSeedlingMintingBatch(t, numSeedlings)
+	mintingBatch = tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(numSeedlings),
+	)
 	err = assetStore.CommitMintingBatch(ctx, mintingBatch)
 	require.NoError(t, err)
 	mintingBatches = noError1(t, assetStore.FetchNonFinalBatches, ctx)
@@ -791,7 +795,9 @@ func TestAddSproutsToBatch(t *testing.T) {
 
 	// First, we'll create a new batch, then add some sample seedlings.
 	// One random seedling will be a reissuance into a specific group.
-	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, numSeedlings)
+	mintingBatch := tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(numSeedlings),
+	)
 	_, seedlingGroups, _ := addRandGroupToBatch(
 		t, assetStore, ctx, mintingBatch.Seedlings,
 	)
@@ -889,7 +895,9 @@ type randAssetCtx struct {
 func addRandAssets(t *testing.T, ctx context.Context,
 	assetStore *AssetMintingStore, numAssets int) randAssetCtx {
 
-	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, numAssets)
+	mintingBatch := tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(numAssets),
+	)
 	genAmt, seedlingGroups, group := addRandGroupToBatch(
 		t, assetStore, ctx, mintingBatch.Seedlings,
 	)
@@ -1397,7 +1405,9 @@ func TestGroupAnchors(t *testing.T) {
 	// internal key and a set of seedlings. One random seedling will
 	// be a reissuance into a specific group. Two other seedlings will form
 	// a multi-asset group.
-	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, numSeedlings)
+	mintingBatch := tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(numSeedlings),
+	)
 	_, seedlingGroups, _ := addRandGroupToBatch(
 		t, assetStore, ctx, mintingBatch.Seedlings,
 	)
@@ -1834,7 +1844,9 @@ func TestUpsertMintAnchorUniCommitment(t *testing.T) {
 	assetStore, _, _ := newAssetStore(t)
 
 	// Create a new batch with one asset group seedling.
-	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, 1)
+	mintingBatch := tapgarden.RandMintingBatch(
+		t, tapgarden.WithTotalSeedlings(1),
+	)
 	mintingBatch.UniverseCommitments = true
 
 	_, _, group := addRandGroupToBatch(

tapgarden/mock.go

@@ -56,13 +56,43 @@ func RandSeedlings(t testing.TB, numSeedlings int) map[string]*Seedling {
 	return seedlings
 }
 
-// RandSeedlingMintingBatch creates a new minting batch with only random
-// seedlings populated for testing.
-func RandSeedlingMintingBatch(t testing.TB, numSeedlings int) *MintingBatch {
+// MintBatchOptions is a set of options for creating a new minting batch.
+type MintBatchOptions struct {
+	// totalSeedlings specifies the number of seedlings to generate in this
+	// minting batch. The seedlings are randomly assigned as grouped or
+	// ungrouped.
+	totalSeedlings int
+}
+
+// MintBatchOption is a functional option for creating a new minting batch.
+type MintBatchOption func(*MintBatchOptions)
+
+// DefaultMintBatchOptions returns a new set of default minting batch options.
+func DefaultMintBatchOptions() MintBatchOptions {
+	return MintBatchOptions{}
+}
+
+// WithTotalSeedlings sets the total number of seedlings to populate in the
+// minting batch.
+func WithTotalSeedlings(count int) MintBatchOption {
+	return func(options *MintBatchOptions) {
+		options.totalSeedlings = count
+	}
+}
+
+// RandMintingBatch creates a new minting batch with only random seedlings
+// populated for testing.
+func RandMintingBatch(t testing.TB, opts ...MintBatchOption) *MintingBatch {
+	// Construct options.
+	options := DefaultMintBatchOptions()
+	for _, opt := range opts {
+		opt(&options)
+	}
+
 	batchKey, _ := test.RandKeyDesc(t)
 	batch := MintingBatch{
 		BatchKey:     batchKey,
-		Seedlings:    RandSeedlings(t, numSeedlings),
+		Seedlings:    RandSeedlings(t, options.totalSeedlings),
 		HeightHint:   test.RandInt[uint32](),
 		CreationTime: time.Now(),
 	}