rpc+multi: rename universe_commitments -> enable_supply_commitments

Renames the field for consistency with updated terminology and boolean
flag conventions elsewhere in the codebase. Field tag remains the same
(15), so wire format is unchanged. The feature is not in use, so this
change is safe despite being technically breaking.

Author: ffranr

cmd/commands/assets.go

@@ -99,7 +99,7 @@ var (
 	groupByGroupName              = "by_group"
 	assetIDName                   = "asset_id"
 	shortResponseName             = "short"
-	universeCommitmentsName       = "universe_commitments"
+	enableSupplyCommitmentsName   = "enable_supply_commitments"
 	feeRateName                   = "sat_per_vbyte"
 	skipProofCourierPingCheckName = "skip-proof-courier-ping-check"
 	assetAmountName               = "amount"
@@ -198,9 +198,9 @@ var mintAssetCommand = cli.Command{
 				"was derived from",
 		},
 		cli.BoolFlag{
-			Name: universeCommitmentsName,
+			Name: enableSupplyCommitmentsName,
 			Usage: "if set, the asset group will be minted with " +
-				"universe commitments enabled " +
+				"universe supply commitments enabled " +
 				"(minter-controlled, on-chain attestations " +
 				"that anchor and verify the state of an " +
 				"asset group); this option restricts the " +
@@ -434,8 +434,10 @@ func mintAsset(ctx *cli.Context) error {
 			AssetVersion: taprpc.AssetVersion(
 				ctx.Uint64(assetVersionName),
 			),
-			ExternalGroupKey:    externalKey,
-			UniverseCommitments: ctx.Bool(universeCommitmentsName),
+			ExternalGroupKey: externalKey,
+			EnableSupplyCommitments: ctx.Bool(
+				enableSupplyCommitmentsName,
+			),
 		},
 		ShortResponse: ctx.Bool(shortResponseName),
 	})

itest/supply_commit_test.go

@@ -89,7 +89,7 @@ func assertAnchorTxPreCommitOut(
 // universe/supply commitments enabled.
 func testPreCommitOutput(t *harnessTest) {
 	mintReq := CopyRequest(issuableAssets[0])
-	mintReq.Asset.UniverseCommitments = true
+	mintReq.Asset.EnableSupplyCommitments = true
 	rpcAssets := MintAssetsConfirmBatch(
 		t.t, t.lndHarness.Miner().Client, t.tapd,
 		[]*mintrpc.MintAssetRequest{mintReq},
@@ -119,7 +119,7 @@ func testPreCommitOutput(t *harnessTest) {
 			GroupedAsset:    true,
 			GroupKey:        tweakedGroupKey,
 
-			UniverseCommitments: true,
+			EnableSupplyCommitments: true,
 		},
 	}
 	rpcAssets = MintAssetsConfirmBatch(
@@ -156,7 +156,7 @@ func testSupplyCommitIgnoreAsset(t *harnessTest) {
 	t.Log("Minting asset group with a single normal asset and " +
 		"universe/supply commitments enabled")
 	mintReq := issuableAssets[0]
-	mintReq.Asset.UniverseCommitments = true
+	mintReq.Asset.EnableSupplyCommitments = true
 	rpcAssets := MintAssetsConfirmBatch(
 		t.t, t.lndHarness.Miner().Client, t.tapd,
 		[]*mintrpc.MintAssetRequest{mintReq},

rpcserver.go

@@ -621,7 +621,7 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 		Amount:              req.Asset.Amount,
 		EnableEmission:      req.Asset.NewGroupedAsset,
 		Meta:                &seedlingMeta,
-		UniverseCommitments: req.Asset.UniverseCommitments,
+		UniverseCommitments: req.Asset.EnableSupplyCommitments,
 	}
 
 	rpcsLog.Infof("[MintAsset]: version=%v, type=%v, name=%v, amt=%v, "+