tapchannel: prop test chanID is not drawn from rapid

Previously we would draw the chanIDs for our channels from the rapid
farmework. This worked for a bit, but after introducing some more strict
checks between the HTLC and the assets within the channel it introduced
some rare failure cases. We now draw the value from rand which is
practically impossible to cause collisions on that value.

Author: GeorgeTsagk

tapchannel/aux_invoice_manager_test.go

@@ -7,6 +7,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"math/big"
+	"math/rand/v2"
 	"testing"
 	"time"
 
@@ -820,11 +821,10 @@ func genHtlc(t *rapid.T, balance []*rfqmsg.AssetBalance,
 // method also returns the assetUnits and the rfqID used by the htlc.
 func genRequest(t *rapid.T) (lndclient.InvoiceHtlcModifyRequest, uint64,
 	asset.ID, rfqmsg.ID) {
-
 	request := lndclient.InvoiceHtlcModifyRequest{
 		CircuitKey: invoices.CircuitKey{
 			ChanID: lnwire.NewShortChanIDFromInt(
-				rapid.Uint64().Draw(t, "chan_id"),
+				rand.Uint64(),
 			),
 		},
 	}