universe: rename BaseBackend.FetchIssuanceProof to FetchProof

Renamed method to better reflect its broader usage. It now applies
to both issuance proof leaves and transfer proof leaves.

Author: ffranr

proof/mock.go

@@ -356,7 +356,7 @@ func (m *MockProofArchive) FetchIssuanceProof(_ context.Context,
 	}
 
 	// Mimic the pattern matching done with proof file paths in
-	// FileArchiver.FetchIssuanceProof().
+	// FileArchiver.FetchProof().
 	matchingHashes := make([][32]byte, 0)
 	locMatcher := func(locBytes [132]byte, locHash [32]byte) error {
 		if bytes.Equal(locBytes[:32], id[:]) &&

tapdb/universe.go

@@ -807,11 +807,11 @@ func universeUpsertProofLeaf(ctx context.Context, dbTx BaseUniverseStore,
 	}, nil
 }
 
-// FetchIssuanceProof returns an issuance proof for the target key. If the key
-// doesn't have a script key specified, then all the proofs for the minting
-// outpoint will be returned. If neither are specified, then proofs for all the
-// inserted leaves will be returned.
-func (b *BaseUniverseTree) FetchIssuanceProof(ctx context.Context,
+// FetchProof retrieves a universe proof corresponding to the given key. If the
+// key omits a script key, all proofs for the specified minting outpoint will be
+// returned. If both the script key and minting outpoint are omitted, proofs for
+// all inserted leaves in the universe will be returned.
+func (b *BaseUniverseTree) FetchProof(ctx context.Context,
 	universeKey universe.LeafKey) ([]*universe.Proof, error) {
 
 	var (

tapdb/universe_test.go

@@ -328,7 +328,7 @@ func TestUniverseIssuanceProofs(t *testing.T) {
 
 		// We should be able to fetch the issuance proof now, using
 		// that very same target key generated.
-		dbProof, err := baseUniverse.FetchIssuanceProof(ctx, targetKey)
+		dbProof, err := baseUniverse.FetchProof(ctx, targetKey)
 		require.NoError(t, err)
 
 		uniProof := dbProof[0]
@@ -481,7 +481,7 @@ func TestUniverseMetaBlob(t *testing.T) {
 
 	// We should be able to fetch the leaf based on the base key we used
 	// above.
-	dbProof, err := baseUniverse.FetchIssuanceProof(ctx, targetKey)
+	dbProof, err := baseUniverse.FetchProof(ctx, targetKey)
 	require.NoError(t, err)
 
 	uniProof := dbProof[0]
@@ -688,7 +688,7 @@ func TestUniverseLeafQuery(t *testing.T) {
 
 	// If we query for only the minting point, then all three leaves should
 	// be returned.
-	proofs, err := baseUniverse.FetchIssuanceProof(
+	proofs, err := baseUniverse.FetchProof(
 		ctx, universe.BaseLeafKey{
 			OutPoint: rootMintingPoint,
 		},
@@ -703,7 +703,7 @@ func TestUniverseLeafQuery(t *testing.T) {
 		scriptKey, err := btcec.ParsePubKey(scriptKeyBytes[:])
 		require.NoError(t, err)
 
-		p, err := baseUniverse.FetchIssuanceProof(
+		p, err := baseUniverse.FetchProof(
 			ctx, universe.BaseLeafKey{
 				OutPoint: rootMintingPoint,
 				ScriptKey: &asset.ScriptKey{
@@ -759,7 +759,7 @@ func TestUniverseLeafOverflow(t *testing.T) {
 
 	// We should be able to fetch the leaf based on the base key we used
 	// above.
-	_, err = baseUniverse.FetchIssuanceProof(ctx, targetKey)
+	_, err = baseUniverse.FetchProof(ctx, targetKey)
 	require.NoError(t, err)
 
 	// If we try to insert another, then this should fail, as the tree will
@@ -771,7 +771,7 @@ func TestUniverseLeafOverflow(t *testing.T) {
 	require.ErrorIs(t, err, mssmt.ErrIntegerOverflow)
 
 	// We should still be able to fetch the original issuance proof.
-	_, err = baseUniverse.FetchIssuanceProof(ctx, targetKey)
+	_, err = baseUniverse.FetchProof(ctx, targetKey)
 	require.NoError(t, err)
 }
 
@@ -877,7 +877,7 @@ func TestUniverseRootSum(t *testing.T) {
 			// Each of the leaves inserted should have the proper
 			// value as well.
 			for i, key := range keys {
-				proofs, err := baseUniverse.FetchIssuanceProof(
+				proofs, err := baseUniverse.FetchProof(
 					ctx, key,
 				)
 				require.NoError(t, err)

universe/interface.go

@@ -414,14 +414,14 @@ type BaseBackend interface {
 	RegisterIssuance(ctx context.Context, key LeafKey, leaf *Leaf,
 		metaReveal *proof.MetaReveal) (*Proof, error)
 
-	// FetchIssuanceProof returns an issuance proof for the target key. If
-	// the key doesn't have a script key specified, then all the proofs for
-	// the minting outpoint will be returned. If neither are specified,
-	// then proofs for all the inserted leaves will be returned.
+	// FetchProof retrieves a universe proof corresponding to the given key.
+	// If the key omits a script key, all proofs for the specified minting
+	// outpoint will be returned. If both the script key and minting
+	// outpoint are omitted, proofs for all inserted leaves in the universe
+	// will be returned.
 	//
 	// TODO(roasbeef): can eventually do multi-proofs for the SMT
-	FetchIssuanceProof(ctx context.Context,
-		key LeafKey) ([]*Proof, error)
+	FetchProof(ctx context.Context, key LeafKey) ([]*Proof, error)
 
 	// FetchKeys retrieves all keys from the universe tree.
 	FetchKeys(ctx context.Context,