rpcserver: return correct policy

guggero · guggero · commit b9bbc1cd2f4e · 2025-06-16T15:12:02.000+02:00
Due to (probably) a copy/paste error, we returned the wrong policy for
an invoice. We didn't notice this because in our integration tests we
never set non-default routing policies.
diff --git a/rpcserver.go b/rpcserver.go
@@ -8553,8 +8553,10 @@ func (r *rpcServer) getInboundPolicy(ctx context.Context, chanID uint64,
 		return nil, fmt.Errorf("unable to fetch channel: %w", err)
 	}
 
+	// We want the policy that corresponds to the node that is the remote
+	// peer in the channel.
 	policy := edge.Node2Policy
-	if edge.Node2Pub == remotePubStr {
+	if edge.Node1Pub == remotePubStr {
 		policy = edge.Node1Policy
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -8553,8 +8553,10 @@ func (r *rpcServer) getInboundPolicy(ctx context.Context, chanID uint64,`
`8553`	`8553`	`return nil, fmt.Errorf("unable to fetch channel: %w", err)`
`8554`	`8554`	`}`
`8555`	`8555`
	`8556`	`+ // We want the policy that corresponds to the node that is the remote`
	`8557`	`+ // peer in the channel.`
`8556`	`8558`	`policy := edge.Node2Policy`
`8557`		`- if edge.Node2Pub == remotePubStr {`
	`8559`	`+ if edge.Node1Pub == remotePubStr {`
`8558`	`8560`	`policy = edge.Node1Policy`
`8559`	`8561`	`}`
`8560`	`8562`