Merge pull request #1500 from lightninglabs/rpc-endpoint-latency-histogram

Roasbeef · web-flow · commit bb5a2a6f154a · 2025-05-07T17:04:45.000-07:00
monitoring: expand Prometheus buckets for RPC endpoint latency
diff --git a/monitoring/monitoring_on.go b/monitoring/monitoring_on.go
@@ -29,7 +29,14 @@ func GetPromInterceptors(cfg *PrometheusConfig) ([]grpc.UnaryServerInterceptor,
 	}
 
 	if cfg.PerfHistograms {
-		opt := grpc_prometheus.WithServerHandlingTimeHistogram()
+		// Set the histogram buckets in seconds.
+		histogramBuckets := []float64{
+			0.01, 0.1, 0.5, 1, 5, 10, 60, 120, 240, 600, 1200,
+		}
+		opt := grpc_prometheus.WithServerHandlingTimeHistogram(
+			grpc_prometheus.WithHistogramBuckets(histogramBuckets),
+		)
+
 		opts = append(opts, opt)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,14 @@ func GetPromInterceptors(cfg *PrometheusConfig) ([]grpc.UnaryServerInterceptor,`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`if cfg.PerfHistograms {`
`32`		`- opt := grpc_prometheus.WithServerHandlingTimeHistogram()`
	`32`	`+ // Set the histogram buckets in seconds.`
	`33`	`+ histogramBuckets := []float64{`
	`34`	`+ 0.01, 0.1, 0.5, 1, 5, 10, 60, 120, 240, 600, 1200,`
	`35`	`+ }`
	`36`	`+ opt := grpc_prometheus.WithServerHandlingTimeHistogram(`
	`37`	`+ grpc_prometheus.WithHistogramBuckets(histogramBuckets),`
	`38`	`+ )`
	`39`	`+`
`33`	`40`	`opts = append(opts, opt)`
`34`	`41`	`}`
`35`	`42`