tapgarden: always notify subscribers on receive complete

This commit moves the notification for subscribers about a transfer
being complete from the proof courier only part to the general function
we end up in if a transfer is complete.

Author: guggero

tapgarden/custodian.go

@@ -498,15 +498,6 @@ func (c *Custodian) receiveProof(addr *address.Tap, op wire.OutPoint) {
 		log.Errorf("Unable to import proofs: %v", err)
 		return
 	}
-
-	// At this point the "receive" process is complete. We will now notify
-	// all status event subscribers.
-	receiveCompleteEvent := NewAssetRecvCompleteEvent(*addr, op)
-	err = c.publishSubscriberStatusEvent(receiveCompleteEvent)
-	if err != nil {
-		log.Errorf("Unable publish status event: %v", err)
-		return
-	}
 }
 
 // mapToTapAddr attempts to match a transaction output to a Taproot Asset
@@ -707,13 +698,23 @@ func (c *Custodian) mapProofToEvent(p proof.Blob) error {
 func (c *Custodian) setReceiveCompleted(event *address.Event,
 	lastProof *proof.Proof, proofFile *proof.File) error {
 
+	// At this point the "receive" process is complete. We will now notify
+	// all status event subscribers.
+	receiveCompleteEvent := NewAssetRecvCompleteEvent(
+		*event.Addr.Tap, event.Outpoint,
+	)
+	err := c.publishSubscriberStatusEvent(receiveCompleteEvent)
+	if err != nil {
+		log.Errorf("Unable publish status event: %v", err)
+	}
+
 	// The proof is created after a single confirmation. To make sure we
 	// notice if the anchor transaction is re-organized out of the chain, we
 	// give all the not-yet-sufficiently-buried proofs in the received proof
 	// file to the re-org watcher and replace the updated proof in the local
 	// proof archive if a re-org happens. The sender will do the same, so no
 	// re-send of the proof is necessary.
-	err := c.cfg.ProofWatcher.MaybeWatch(
+	err = c.cfg.ProofWatcher.MaybeWatch(
 		proofFile, c.cfg.ProofWatcher.DefaultUpdateCallback(),
 	)
 	if err != nil {