Accept price deviation ppm configuration (#1109)

* Add AcceptPriceDeviationPpm configuration

---------

Co-authored-by: luke <[email protected]>

Author: lukegao209

rfq/cli.go

@@ -22,6 +22,8 @@ const (
 type CliConfig struct {
 	PriceOracleAddress string `long:"priceoracleaddress" description:"Price oracle gRPC server address (rfqrpc://<hostname>:<port>). To use the integrated mock, use the following value: use_mock_price_oracle_service_promise_to_not_use_on_mainnet"`
 
+	AcceptPriceDeviationPpm uint64 `long:"acceptpricedeviationppm" description:"The default price deviation in parts per million that is accepted by the RFQ negotiator"`
+
 	SkipAcceptQuotePriceCheck bool `long:"skipacceptquotepricecheck" description:"Accept any price quote returned by RFQ peer, skipping price validation"`
 
 	MockOracleAssetsPerBTC uint64 `long:"mockoracleassetsperbtc" description:"Mock price oracle static asset units per BTC rate (for example number of USD cents per BTC if one asset unit represents a USD cent); whole numbers only, use either this or mockoraclesatsperasset depending on required precision"`

rfq/manager.go

@@ -75,6 +75,12 @@ type ManagerCfg struct {
 	// into the manager once lnd and tapd are hooked together.
 	AliasManager ScidAliasManager
 
+	// AcceptPriceDeviationPpm is the price deviation in
+	// parts per million that is accepted by the RFQ negotiator.
+	//
+	// Example: 50,000 ppm => price deviation is set to 5% .
+	AcceptPriceDeviationPpm uint64
+
 	// SkipAcceptQuotePriceCheck is a flag that, when set, will cause the
 	// RFQ negotiator to skip price validation on incoming quote accept
 	// messages (this means that the price oracle will not be queried).
@@ -226,7 +232,7 @@ func (m *Manager) startSubsystems(ctx context.Context) error {
 		NegotiatorCfg{
 			PriceOracle:               m.cfg.PriceOracle,
 			OutgoingMessages:          m.outgoingMessages,
-			AcceptPriceDeviationPpm:   DefaultAcceptPriceDeviationPpm,
+			AcceptPriceDeviationPpm:   m.cfg.AcceptPriceDeviationPpm,
 			SkipAcceptQuotePriceCheck: m.cfg.SkipAcceptQuotePriceCheck,
 			ErrChan:                   m.subsystemErrChan,
 		},

sample-tapd.conf

@@ -310,13 +310,18 @@
 ; (latency, etc)
 ; prometheus.perfhistograms=false
 
-[experimental.rfq]
+[experimental]
 
 ; Price oracle gRPC server address (rfqrpc://<hostname>:<port>)
 ; To use the integrated mock, use the following value:
 ; use_mock_price_oracle_service_promise_to_not_use_on_mainnet
 ; experimental.rfq.priceoracleaddress=
 
+; The default price deviation inparts per million that is accepted by 
+; the RFQ negotiator.
+; Example: 50,000 ppm => price deviation is set to 5% .
+; experimental.rfq.acceptpricedeviationppm=50000
+
 ; Accept any price quote returned by RFQ peer, skipping price validation
 ; experimental.rfq.skipacceptquotepricecheck=false
 

tapcfg/config.go

@@ -428,7 +428,12 @@ func DefaultConfig() Config {
 		AddrBook: &AddrBookConfig{
 			DisableSyncer: false,
 		},
-		Experimental: &ExperimentalConfig{},
+		// nolint: lll
+		Experimental: &ExperimentalConfig{
+			Rfq: rfq.CliConfig{
+				AcceptPriceDeviationPpm: rfq.DefaultAcceptPriceDeviationPpm,
+			},
+		},
 	}
 }
 

tapcfg/server.go

@@ -373,6 +373,8 @@ func genServerConfig(cfg *Config, cfgLogger btclog.Logger,
 			ChannelLister:   walletAnchor,
 			AliasManager:    lndRouterClient,
 			// nolint: lll
+			AcceptPriceDeviationPpm: rfqCfg.AcceptPriceDeviationPpm,
+			// nolint: lll
 			SkipAcceptQuotePriceCheck: rfqCfg.SkipAcceptQuotePriceCheck,
 			ErrChan:                   mainErrChan,
 		},