Merge pull request #1325 from lightninglabs/unit-commitment-mint-output

Add pre-commitment output to mint anchor TX

Author: Roasbeef

cmd/commands/assets.go

@@ -59,6 +59,7 @@ var (
 	groupByGroupName             = "by_group"
 	assetIDName                  = "asset_id"
 	shortResponseName            = "short"
+	universeCommitmentsName      = "universe_commitments"
 	feeRateName                  = "sat_per_vbyte"
 	assetAmountName              = "amount"
 	burnOverrideConfirmationName = "override_confirmation_destroy_assets"
@@ -154,6 +155,15 @@ var mintAssetCommand = cli.Command{
 			Usage: "the master fingerprint of the key the xpub " +
 				"was derived from",
 		},
+		cli.BoolFlag{
+			Name: universeCommitmentsName,
+			Usage: "if set, the asset group will be minted with " +
+				"universe commitments enabled " +
+				"(minter-controlled, on-chain attestations " +
+				"that anchor and verify the state of an " +
+				"asset group); this option restricts the " +
+				"minting batch to a single asset group",
+		},
 	},
 	Action: mintAsset,
 	Subcommands: []cli.Command{
@@ -382,7 +392,8 @@ func mintAsset(ctx *cli.Context) error {
 			AssetVersion: taprpc.AssetVersion(
 				ctx.Uint64(assetVersionName),
 			),
-			ExternalGroupKey: externalKey,
+			ExternalGroupKey:    externalKey,
+			UniverseCommitments: ctx.Bool(universeCommitmentsName),
 		},
 		ShortResponse: ctx.Bool(shortResponseName),
 	})

proof/meta.go

@@ -174,12 +174,6 @@ type MetaReveal struct {
 	UnknownOddTypes tlv.TypeMap
 }
 
-// SizableInteger is a subset of Integer that excludes int8, since we never use
-// it in practice.
-type SizableInteger interface {
-	constraints.Unsigned | ~int | ~int16 | ~int32 | ~int64
-}
-
 // Validate validates the meta reveal.
 func (m *MetaReveal) Validate() error {
 	// A meta reveal is allowed to be nil.
@@ -234,6 +228,13 @@ func (m *MetaReveal) Validate() error {
 		return err
 	}
 
+	// The asset metadata is invalid when the universe commitments feature
+	// is enabled but no delegation key is specified.
+	if m.UniverseCommitments && m.DelegationKey.IsNone() {
+		return fmt.Errorf("universe commitments enabled in asset " +
+			"metadata but delegation key is unspecified")
+	}
+
 	return fn.MapOptionZ(m.DelegationKey, func(key btcec.PublicKey) error {
 		if key == emptyKey {
 			return ErrDelegationKeyEmpty
@@ -247,6 +248,12 @@ func (m *MetaReveal) Validate() error {
 	})
 }
 
+// SizableInteger is a subset of Integer that excludes int8, since we never use
+// it in practice.
+type SizableInteger interface {
+	constraints.Unsigned | ~int | ~int16 | ~int32 | ~int64
+}
+
 // IsValidMetaType checks if the passed value is a valid meta type.
 func IsValidMetaType[T SizableInteger](num T) (MetaType, error) {
 	switch {
@@ -288,6 +295,8 @@ func IsValidDecDisplay(decDisplay uint32) error {
 
 // DecodeMetaJSON decodes bytes as a JSON object, after checking that the bytes
 // could be valid metadata.
+//
+// TODO(ffranr): Add unit test for `jBytes := []byte{}`.
 func DecodeMetaJSON(jBytes []byte) (map[string]interface{}, error) {
 	jMeta := make(map[string]interface{})
 

rpcserver.go

@@ -508,7 +508,10 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 			"collectibles")
 	}
 
-	var seedlingMeta *proof.MetaReveal
+	// TODO(ffranr): Move seedling MetaReveal construction into
+	//  ChainPlanter. This will allow us to simplify delegation key
+	//  management.
+	var seedlingMeta proof.MetaReveal
 	switch {
 	// If we have an explicit asset meta field, we parse the content.
 	case req.Asset.AssetMeta != nil:
@@ -520,7 +523,7 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 
 		// If the asset meta field was specified, then the data inside
 		// must be valid. Let's check that now.
-		seedlingMeta = &proof.MetaReveal{
+		seedlingMeta = proof.MetaReveal{
 			Data: req.Asset.AssetMeta.Data,
 			Type: metaType,
 		}
@@ -542,15 +545,10 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 			return nil, err
 		}
 
-		err = seedlingMeta.Validate()
-		if err != nil {
-			return nil, err
-		}
-
 	// If no asset meta field was specified, we create a default meta
 	// reveal with the decimal display set.
 	default:
-		seedlingMeta = &proof.MetaReveal{
+		seedlingMeta = proof.MetaReveal{
 			Type: proof.MetaOpaque,
 		}
 
@@ -560,11 +558,6 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 		if err != nil {
 			return nil, err
 		}
-
-		err = seedlingMeta.Validate()
-		if err != nil {
-			return nil, err
-		}
 	}
 
 	// Parse the optional script key and group internal key. The group
@@ -602,12 +595,13 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 	}
 
 	seedling := &tapgarden.Seedling{
-		AssetVersion:   assetVersion,
-		AssetType:      asset.Type(req.Asset.AssetType),
-		AssetName:      req.Asset.Name,
-		Amount:         req.Asset.Amount,
-		EnableEmission: req.Asset.NewGroupedAsset,
-		Meta:           seedlingMeta,
+		AssetVersion:        assetVersion,
+		AssetType:           asset.Type(req.Asset.AssetType),
+		AssetName:           req.Asset.Name,
+		Amount:              req.Asset.Amount,
+		EnableEmission:      req.Asset.NewGroupedAsset,
+		Meta:                &seedlingMeta,
+		UniverseCommitments: req.Asset.UniverseCommitments,
 	}
 
 	rpcsLog.Infof("[MintAsset]: version=%v, type=%v, name=%v, amt=%v, "+

tapcfg/server.go

@@ -534,10 +534,8 @@ func genServerConfig(cfg *Config, cfgLogger btclog.Logger,
 		RuntimeID:             runtimeID,
 		EnableChannelFeatures: enableChannelFeatures,
 		Lnd:                   lndServices,
-		ChainParams: address.ParamsForChain(
-			cfg.ActiveNetParams.Name,
-		),
-		ReOrgWatcher: reOrgWatcher,
+		ChainParams:           tapChainParams,
+		ReOrgWatcher:          reOrgWatcher,
 		AssetMinter: tapgarden.NewChainPlanter(tapgarden.PlanterConfig{
 			GardenKit: tapgarden.GardenKit{
 				Wallet:                walletAnchor,
@@ -553,6 +551,7 @@ func genServerConfig(cfg *Config, cfgLogger btclog.Logger,
 				ProofWatcher:          reOrgWatcher,
 				UniversePushBatchSize: defaultUniverseSyncBatchSize,
 			},
+			ChainParams:  tapChainParams,
 			ProofUpdates: proofArchive,
 			ErrChan:      mainErrChan,
 		}),