Merge pull request #1734 from bhandras/listassets-fixups

cmd: asset list to correctly filter on and display anchor txid

Author: guggero

cmd/commands/assets.go

@@ -1243,29 +1243,46 @@ var listTransfersCommand = cli.Command{
 	Name:      "transfers",
 	ShortName: "t",
 	Usage:     "list asset transfers",
-	Description: "list outgoing transfers of all assets or a selected " +
-		"asset",
+	Description: "list outgoing transfer for a specific anchor or if " +
+		"not set, all transfers",
 	Action: listTransfers,
 	Flags: []cli.Flag{
 		cli.StringFlag{
-			Name: assetIDName,
-			Usage: "A specific asset ID to list outgoing " +
-				"transfers for",
+			Name: anchorTxidName,
+			Usage: "A specific anchor transaction ID to run the " +
+				" transfer query against. If not set, all " +
+				" transfers will be returned.",
 		},
 	},
 }
 
+// reverseByteOrder reverses the byte order of the byte slice in place.
+func reverseByteOrder(b []byte) {
+	for i, j := 0, len(b)-1; i < j; i, j = i+1, j-1 {
+		b[i], b[j] = b[j], b[i]
+	}
+}
+
 func listTransfers(ctx *cli.Context) error {
 	ctxc := getContext()
 	client, cleanUp := getClient(ctx)
 	defer cleanUp()
 
-	req := &taprpc.ListTransfersRequest{}
+	req := &taprpc.ListTransfersRequest{
+		AnchorTxid: ctx.String(anchorTxidName),
+	}
 	resp, err := client.ListTransfers(ctxc, req)
 	if err != nil {
 		return fmt.Errorf("unable to list asset transfers: %w", err)
 	}
 
+	// As the anchor TX hash is returned in a byte slice we need to reverse
+	// the byte order to match the expected hex format of string serialized
+	// transaction IDs.
+	for _, transfer := range resp.Transfers {
+		reverseByteOrder(transfer.AnchorTxHash)
+	}
+
 	printRespJSON(resp)
 	return nil
 }

taprpc/assetwalletrpc/assetwallet.swagger.json

@@ -950,7 +950,7 @@
         "anchor_tx_hash": {
           "type": "string",
           "format": "byte",
-          "description": "The new transaction that commits to the set of Taproot Assets found\nat the above new anchor point."
+          "description": "The new transaction that commits to the set of Taproot Assets found at\nthe above new anchor point. Note that this is in raw byte format, not\nthe reversed hex string format that is used for displayed txids. When\nlisting assets on the CLI we purposefully use the display format so it\nis easier to copy and paste into other tools."
         },
         "anchor_tx_height_hint": {
           "type": "integer",

taprpc/taprootassets.pb.go

@@ -799,8 +799,11 @@ message AssetTransfer {
     // The timestamp of the transfer in UTC Unix time seconds.
     int64 transfer_timestamp = 1;
 
-    // The new transaction that commits to the set of Taproot Assets found
-    // at the above new anchor point.
+    // The new transaction that commits to the set of Taproot Assets found at
+    // the above new anchor point. Note that this is in raw byte format, not
+    // the reversed hex string format that is used for displayed txids. When
+    // listing assets on the CLI we purposefully use the display format so it
+    // is easier to copy and paste into other tools.
     bytes anchor_tx_hash = 2;
 
     // The height hint of the anchor transaction. This is the height at which

taprpc/taprootassets.proto

@@ -1671,7 +1671,7 @@
         "anchor_tx_hash": {
           "type": "string",
           "format": "byte",
-          "description": "The new transaction that commits to the set of Taproot Assets found\nat the above new anchor point."
+          "description": "The new transaction that commits to the set of Taproot Assets found at\nthe above new anchor point. Note that this is in raw byte format, not\nthe reversed hex string format that is used for displayed txids. When\nlisting assets on the CLI we purposefully use the display format so it\nis easier to copy and paste into other tools."
         },
         "anchor_tx_height_hint": {
           "type": "integer",