cmd+rpcserver+taprpc: filter unconfirmed assets by default

By default, we only want to show assets in the asset list that are ready
to be spent. So we don't want to include not yet confirmed freshly
minted assets (those are the only assets that are materialized in the
asset table while not being confirmed yet).
We add a new RPC and CLI flag that allows the user to show the assets on
explicit request.

Author: guggero

cmd/tapcli/assets.go

@@ -47,6 +47,7 @@ var (
 	assetGroupedAssetName        = "grouped_asset"
 	assetShowWitnessName         = "show_witness"
 	assetShowSpentName           = "show_spent"
+	assetShowUnconfMintsName     = "show_unconfirmed_mints"
 	assetGroupKeyName            = "group_key"
 	assetGroupAnchorName         = "group_anchor"
 	batchKeyName                 = "batch_key"
@@ -554,6 +555,11 @@ var listAssetsCommand = cli.Command{
 			Name:  assetShowSpentName,
 			Usage: "include fully spent assets in the list",
 		},
+		cli.BoolFlag{
+			Name: assetShowUnconfMintsName,
+			Usage: "include freshly minted and not yet confirmed " +
+				"assets in the list",
+		},
 	},
 	Action: listAssets,
 }
@@ -566,8 +572,9 @@ func listAssets(ctx *cli.Context) error {
 	// TODO(roasbeef): need to reverse txid
 
 	resp, err := client.ListAssets(ctxc, &taprpc.ListAssetRequest{
-		WithWitness:  ctx.Bool(assetShowWitnessName),
-		IncludeSpent: ctx.Bool(assetShowSpentName),
+		WithWitness:             ctx.Bool(assetShowWitnessName),
+		IncludeSpent:            ctx.Bool(assetShowSpentName),
+		IncludeUnconfirmedMints: ctx.Bool(assetShowUnconfMintsName),
 	})
 	if err != nil {
 		return fmt.Errorf("unable to list assets: %w", err)

itest/utils.go

@@ -358,7 +358,9 @@ func FinalizeBatchUnconfirmed(t *testing.T, minerClient *rpcclient.Client,
 	// Make sure the assets were all minted within the same anchor but don't
 	// yet have a block hash associated with them.
 	listRespUnconfirmed, err := tapClient.ListAssets(
-		ctxt, &taprpc.ListAssetRequest{},
+		ctxt, &taprpc.ListAssetRequest{
+			IncludeUnconfirmedMints: true,
+		},
 	)
 	require.NoError(t, err)
 

rpcserver.go

@@ -975,6 +975,37 @@ func (r *rpcServer) ListAssets(ctx context.Context,
 		return nil, err
 	}
 
+	var (
+		filteredAssets   []*taprpc.Asset
+		unconfirmedMints uint64
+	)
+
+	// We now count and filter the assets according to the
+	// IncludeUnconfirmedMints flag.
+	//
+	// TODO(guggero): Do this on the SQL level once we add pagination to the
+	// asset list query, as this will no longer work with pagination.
+	for idx := range rpcAssets {
+		switch {
+		// If the asset isn't confirmed yet, we count it but only
+		// include it in the output list if the client requested it.
+		case rpcAssets[idx].ChainAnchor.BlockHeight == 0:
+			unconfirmedMints++
+
+			if req.IncludeUnconfirmedMints {
+				filteredAssets = append(
+					filteredAssets, rpcAssets[idx],
+				)
+			}
+
+		// Don't filter out confirmed assets.
+		default:
+			filteredAssets = append(
+				filteredAssets, rpcAssets[idx],
+			)
+		}
+	}
+
 	// We will also report the number of unconfirmed transfers. This is
 	// useful for clients as unconfirmed asset coins are not included in the
 	// asset list.
@@ -985,8 +1016,9 @@ func (r *rpcServer) ListAssets(ctx context.Context,
 	}
 
 	return &taprpc.ListAssetResponse{
-		Assets:               rpcAssets,
+		Assets:               filteredAssets,
 		UnconfirmedTransfers: uint64(len(outboundParcels)),
+		UnconfirmedMints:     unconfirmedMints,
 	}, nil
 }