From 1c92cae08fced1ffba6c6f2c3a7f2a5ded92599c Mon Sep 17 00:00:00 2001 From: George Tsagkarelis Date: Wed, 24 Sep 2025 16:05:38 +0200 Subject: [PATCH 1/3] test: avoid non-constant format string in printf In preparation to the next commit which will bump the golang version we want to avoid calling printf with non-constant format strings. This needs to be done as the govet will include a new rule that prohibits exactly that -- calling into printf with non-constant format strings. --- internal/test/copy.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/test/copy.go b/internal/test/copy.go index 8e1ec1e24f..e4dfce4439 100644 --- a/internal/test/copy.go +++ b/internal/test/copy.go @@ -237,7 +237,7 @@ func checkAliasing(t *testing.T, debug, strict bool, f1, f2 reflect.Value, "(shared %s)", path, f1.Kind()) if strict { - t.Fatalf(msg) + t.Fatal(msg) } if debug { From 095b93badaec2603f890c991ffab973bf11d1cec Mon Sep 17 00:00:00 2001 From: George Tsagkarelis Date: Wed, 24 Sep 2025 16:06:56 +0200 Subject: [PATCH 2/3] build: bump golang to v1.24.6 --- .github/workflows/main.yaml | 2 +- .github/workflows/release.yaml | 2 +- Dockerfile | 2 +- Makefile | 2 +- dev.Dockerfile | 2 +- docs/examples/basic-price-oracle/go.mod | 2 +- go.mod | 2 +- itest/loadtest/Dockerfile | 2 +- make/builder.Dockerfile | 2 +- taprpc/Dockerfile | 2 +- taprpc/go.mod | 2 +- tools/Dockerfile | 2 +- tools/go.mod | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 538524d81b..9787d2311e 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -19,7 +19,7 @@ env: # go needs absolute directories, using the $HOME variable doesn't work here. GOPATH: /home/runner/work/go - GO_VERSION: '1.23.12' + GO_VERSION: '1.24.6' LITD_ITEST_BRANCH: 'tapd-main-branch' diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 97ed687252..f4f99e535a 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -10,7 +10,7 @@ defaults: shell: bash env: - GO_VERSION: 1.23.12 + GO_VERSION: 1.24.6 jobs: main: diff --git a/Dockerfile b/Dockerfile index bd6c336a44..e234e01359 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23.12-alpine as builder +FROM golang:1.24.6-alpine as builder # Force Go to use the cgo based DNS resolver. This is required to ensure DNS # queries required to connect to linked containers succeed. diff --git a/Makefile b/Makefile index 631a0a81e9..42ca4d18d2 100644 --- a/Makefile +++ b/Makefile @@ -57,7 +57,7 @@ DOCKER_TOOLS = docker run \ -v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \ -v $$(pwd):/build taproot-assets-tools -GO_VERSION = 1.23.12 +GO_VERSION = 1.24.6 GREEN := "\\033[0;32m" NC := "\\033[0m" diff --git a/dev.Dockerfile b/dev.Dockerfile index 5e2b2ac3fb..49e74904cc 100644 --- a/dev.Dockerfile +++ b/dev.Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23.12 as builder +FROM golang:1.24.6 as builder WORKDIR /app diff --git a/docs/examples/basic-price-oracle/go.mod b/docs/examples/basic-price-oracle/go.mod index 9745ced5d0..4135bfa5a2 100644 --- a/docs/examples/basic-price-oracle/go.mod +++ b/docs/examples/basic-price-oracle/go.mod @@ -1,6 +1,6 @@ module basic-price-oracle -go 1.23.12 +go 1.24.6 // We want to format raw bytes as hex instead of base64. The forked version // allows us to specify that as an option. diff --git a/go.mod b/go.mod index a3217e3ab2..249c949c62 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/lightninglabs/taproot-assets -go 1.23.12 +go 1.24.6 require ( github.com/btcsuite/btcd v0.24.3-0.20250318170759-4f4ea81776d6 diff --git a/itest/loadtest/Dockerfile b/itest/loadtest/Dockerfile index a4c878b98f..d836a40387 100644 --- a/itest/loadtest/Dockerfile +++ b/itest/loadtest/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23.12 as builder +FROM golang:1.24.6 as builder WORKDIR /app diff --git a/make/builder.Dockerfile b/make/builder.Dockerfile index f960cc2a50..c5ab92b857 100644 --- a/make/builder.Dockerfile +++ b/make/builder.Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23.12-bookworm +FROM golang:1.24.6-bookworm MAINTAINER Olaoluwa Osuntokun diff --git a/taprpc/Dockerfile b/taprpc/Dockerfile index a4736e0292..a5cc073bf5 100644 --- a/taprpc/Dockerfile +++ b/taprpc/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23.12-bookworm +FROM golang:1.24.6-bookworm RUN apt-get update && apt-get install -y \ git \ diff --git a/taprpc/go.mod b/taprpc/go.mod index 22a7059885..27ef7e84ba 100644 --- a/taprpc/go.mod +++ b/taprpc/go.mod @@ -1,6 +1,6 @@ module github.com/lightninglabs/taproot-assets/taprpc -go 1.23.12 +go 1.24.6 require ( github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 diff --git a/tools/Dockerfile b/tools/Dockerfile index 69b86cc6c0..95d70e2495 100644 --- a/tools/Dockerfile +++ b/tools/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.24.5-bookworm +FROM golang:1.24.6-bookworm RUN apt-get update && apt-get install -y git ENV GOCACHE=/tmp/build/.cache diff --git a/tools/go.mod b/tools/go.mod index 7f94310d0b..930ff31019 100644 --- a/tools/go.mod +++ b/tools/go.mod @@ -1,6 +1,6 @@ module github.com/lightninglabs/taproot-assets/tools -go 1.24.5 +go 1.24.6 require ( github.com/btcsuite/btcd v0.24.2 From 00854063b796ca280442398ddcb7f872cf6547f3 Mon Sep 17 00:00:00 2001 From: George Tsagkarelis Date: Wed, 24 Sep 2025 16:16:04 +0200 Subject: [PATCH 3/3] docs: add release note --- docs/release-notes/release-notes-0.7.0.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/release-notes/release-notes-0.7.0.md b/docs/release-notes/release-notes-0.7.0.md index 8949b03241..6788ff241f 100644 --- a/docs/release-notes/release-notes-0.7.0.md +++ b/docs/release-notes/release-notes-0.7.0.md @@ -238,6 +238,12 @@ `ChainPorter` state machine by removing a goroutine and simplifying event emission. Fixes an itest flake. +- [The Golang version used was bumped to `v1.23.12` to fix a potential issue + with the SQL API](https://github.com/lightninglabs/taproot-assets/pull/1713). + +- [The Golang version used was bumped to `v1.24.6` in order to keep up with the + dependencies (LND).](https://github.com/lightninglabs/taproot-assets/pull/1815) + ## Breaking Changes ## Performance Improvements @@ -252,11 +258,6 @@ ## Database -## Code Health - -- [The Golang version used was bumped to `v1.23.12` to fix a potential issue - with the SQL API](https://github.com/lightninglabs/taproot-assets/pull/1713). - ## Tooling and Documentation - [Two new sequence diagrams were