Skip to content

Commit 4e5728f

Browse files
authored
Merge pull request #8974 from ellemouton/falafelUpdate
lnrpc: update falafel version
2 parents f341d4c + 2d00859 commit 4e5728f

File tree

20 files changed

+24
-31
lines changed

20 files changed

+24
-31
lines changed

docs/release-notes/release-notes-0.18.3.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,10 @@ commitment when the channel was force closed.
118118
* [Added](https://github.com/lightningnetwork/lnd/pull/8836) a new failure
119119
reason `FailureReasonCanceled` to the list of payment failure reasons. It
120120
indicates that a payment was manually cancelled by the user.
121+
122+
* [Update the version](https://github.com/lightningnetwork/lnd/pull/8974) of
123+
[falafel](https://github.com/lightninglabs/falafel) used to generate JSON/wasm
124+
stubs. This latest version of falafel also supports proto3 optional fields.
121125

122126
## Breaking Changes
123127
## Performance Improvements

lnrpc/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ARG PROTOBUF_VERSION
1212
ARG GRPC_GATEWAY_VERSION
1313

1414
ENV PROTOC_GEN_GO_GRPC_VERSION="v1.1.0"
15-
ENV FALAFEL_VERSION="v0.9.1"
15+
ENV FALAFEL_VERSION="v0.9.2"
1616
ENV GOCACHE=/tmp/build/.cache
1717
ENV GOMODCACHE=/tmp/build/.modcache
1818

lnrpc/autopilotrpc/autopilot.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/chainrpc/chainkit.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/chainrpc/chainnotifier.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/devrpc/dev.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/gen_protos.sh

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,7 @@ function generate() {
5050

5151
PACKAGES="autopilotrpc chainrpc invoicesrpc neutrinorpc peersrpc routerrpc signrpc verrpc walletrpc watchtowerrpc wtclientrpc devrpc"
5252
for package in $PACKAGES; do
53-
# Special import for the wallet kit.
54-
manual_import=""
55-
if [[ "$package" == "walletrpc" ]]; then
56-
manual_import="github.com/lightningnetwork/lnd/lnrpc/signrpc"
57-
fi
58-
59-
# Special import for devrpc.
60-
if [[ "$package" == "devrpc" ]]; then
61-
manual_import="github.com/lightningnetwork/lnd/lnrpc"
62-
fi
63-
64-
opts="package_name=$package,manual_import=$manual_import,js_stubs=1"
53+
opts="package_name=$package,js_stubs=1"
6554
pushd $package
6655
protoc -I/usr/local/include -I. -I.. \
6756
--plugin=protoc-gen-custom=$falafel\

lnrpc/invoicesrpc/invoices.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/lightning.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lnrpc/neutrinorpc/neutrinokit.pb.json.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)