Skip to content

Commit 8939a21

Browse files
authored
Merge pull request #9021 from aakselrod/run-nativesql-itests
itest: ensure LND gets correct CLI options when itest are parallel
2 parents dcd921a + 302c690 commit 8939a21

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

docs/release-notes/release-notes-0.18.3.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ would create a blinded route with a minHTLC greater than the actual payment
7373
amount. Moreover remove strict correlation between min_cltv_delta and the
7474
blinded path expiry.
7575

76+
* [Fixed](https://github.com/lightningnetwork/lnd/pull/9021) an issue with some
77+
command-line arguments not being passed when running `make itest-parallel`.
78+
7679
# New Features
7780
## Functional Enhancements
7881
## RPC Additions

scripts/itest_parallel.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,17 @@
33
# Get all the variables.
44
PROCESSES=$1
55
TRANCHES=$2
6-
TEST_FLAGS=$3
7-
ITEST_FLAGS=$4
6+
7+
# Here we also shift 2 times and get the rest of our flags to pass on in $@.
8+
shift 2
89

910
# Create a variable to hold the final exit code.
1011
exit_code=0
1112

1213
# Run commands using xargs in parallel and capture their PIDs
1314
pids=()
1415
for ((i=0; i<PROCESSES; i++)); do
15-
scripts/itest_part.sh $i $TRANCHES $TEST_FLAGS $ITEST_FLAGS &
16+
scripts/itest_part.sh $i $TRANCHES $@ &
1617
pids+=($!)
1718
done
1819

0 commit comments

Comments
 (0)