multi: context.Background() -> t.Context()

Use the new feature of Go 1.24, fix linter warnings.

This change was produced by:
 - running golangci-lint run --fix
 - sed 's/context.Background/t.Context/' -i `git grep -l context.Background | grep test.go`
 - manually fixing broken tests
 - itest, lntest: use ht.Context() where ht or hn is available
 - in HarnessNode.Stop() we keep using context.Background(), because it is
   called from a cleanup handler in which t.Context() is canceled already.

Author: starius

accessman_test.go

@@ -1,7 +1,6 @@
 package lnd
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -490,7 +489,7 @@ func TestAssignPeerPermsBypassExisting(t *testing.T) {
 func TestHasPeer(t *testing.T) {
 	t.Parallel()
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create a testing accessMan.
 	a := &accessMan{
@@ -708,7 +707,7 @@ func TestAddPeerAccessOutbound(t *testing.T) {
 // accessman's internal state based on the peer's status.
 func TestRemovePeerAccess(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create a testing accessMan.
 	a := &accessMan{

autopilot/betweenness_centrality_test.go

@@ -1,7 +1,6 @@
 package autopilot
 
 import (
-	"context"
 	"fmt"
 	"testing"
 
@@ -32,7 +31,7 @@ func TestBetweennessCentralityMetricConstruction(t *testing.T) {
 // Tests that empty graph results in empty centrality result.
 func TestBetweennessCentralityEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	centralityMetric, err := NewBetweennessCentralityMetric(1)
 	require.NoError(
@@ -64,7 +63,7 @@ func TestBetweennessCentralityEmptyGraph(t *testing.T) {
 // Test betweenness centrality calculating using an example graph.
 func TestBetweennessCentralityWithNonEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	workers := []int{1, 3, 9, 100}
 

autopilot/externalscoreattach_test.go

@@ -1,7 +1,6 @@
 package autopilot_test
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -23,7 +22,7 @@ func randKey() (*btcec.PublicKey, error) {
 // ExternalScoreAttachment correctly reflects the scores we set last.
 func TestSetNodeScores(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	const name = "externalscore"
 

autopilot/prefattach_test.go

@@ -76,7 +76,7 @@ var chanGraphs = []struct {
 // empty graph, the NodeSores function always returns a score of 0.
 func TestPrefAttachmentSelectEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	prefAttach := NewPrefAttachment()
 
 	// Create a random public key, which we will query to get a score for.
@@ -116,7 +116,7 @@ func TestPrefAttachmentSelectEmptyGraph(t *testing.T) {
 // and the funds are appropriately allocated across each peer.
 func TestPrefAttachmentSelectTwoVertexes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 
@@ -203,7 +203,7 @@ func TestPrefAttachmentSelectTwoVertexes(t *testing.T) {
 // allocate all funds to each vertex (up to the max channel size).
 func TestPrefAttachmentSelectGreedyAllocation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 
@@ -316,7 +316,7 @@ func TestPrefAttachmentSelectGreedyAllocation(t *testing.T) {
 // of zero during scoring.
 func TestPrefAttachmentSelectSkipNodes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 

autopilot/top_centrality_test.go

@@ -1,7 +1,6 @@
 package autopilot
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -59,7 +58,7 @@ func testTopCentrality(t *testing.T, graph testGraph,
 		// Attempt to get centrality scores and expect
 		// that the result equals with the expected set.
 		scores, err := topCentrality.NodeScores(
-			context.Background(), graph, channels, chanSize, nodes,
+			t.Context(), graph, channels, chanSize, nodes,
 		)
 
 		require.NoError(t, err)

batch/batch_test.go

@@ -1,7 +1,6 @@
 package batch
 
 import (
-	"context"
 	"database/sql"
 	"encoding/binary"
 	"errors"
@@ -31,7 +30,7 @@ var batchTestIntervals = []time.Duration{
 // TestRetry tests the retry logic of the batch scheduler.
 func TestRetry(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	dbDir := t.TempDir()
 
@@ -99,7 +98,7 @@ func TestRetry(t *testing.T) {
 // and then continue to add a write transaction to the same batch.
 func TestReadOnly(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	t.Run("bbolt-ReadWrite", func(t *testing.T) {
 		db, err := walletdb.Create(
@@ -455,7 +454,7 @@ func BenchmarkBoltBatching(b *testing.B) {
 	// batchTest benches the performance of the batch scheduler configured
 	// with/without the LazyAdd option and with the given commit interval.
 	batchTest := func(b *testing.B, lazy bool, interval time.Duration) {
-		ctx := context.Background()
+		ctx := b.Context()
 
 		db := setUpDB(b)
 
@@ -549,7 +548,7 @@ func benchmarkSQLBatching(b *testing.B, sqlite bool) {
 		)
 	}
 
-	ctx := context.Background()
+	ctx := b.Context()
 	opts := sqldb.WriteTxOpt()
 
 	// writeRecord is a helper that adds a single new invoice to the

chanbackup/backup_test.go

@@ -121,8 +121,7 @@ func TestFetchBackupForChan(t *testing.T) {
 	}
 	for i, testCase := range testCases {
 		_, err := FetchBackupForChan(
-			context.Background(), testCase.chanPoint, chanSource,
-			chanSource,
+			t.Context(), testCase.chanPoint, chanSource, chanSource,
 		)
 		switch {
 		// If this is a valid test case, and we failed, then we'll
@@ -143,7 +142,7 @@ func TestFetchBackupForChan(t *testing.T) {
 // channel source for all channels and construct a Single for each channel.
 func TestFetchStaticChanBackups(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll make the set of channels that we want to seed the
 	// channel source with. Both channels will be fully populated in the

chanbackup/pubsub_test.go

@@ -81,7 +81,7 @@ func (m *mockChannelNotifier) SubscribeChans(_ context.Context,
 // channel subscription, then the entire sub-swapper will fail to start.
 func TestNewSubSwapperSubscribeFail(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	keyRing := &lnencrypt.MockKeyRing{}
 
@@ -159,7 +159,7 @@ func TestSubSwapperIdempotentStartStop(t *testing.T) {
 
 	swapper := newMockSwapper(keyRing)
 	subSwapper, err := NewSubSwapper(
-		context.Background(), nil, &chanNotifier, keyRing, swapper,
+		t.Context(), nil, &chanNotifier, keyRing, swapper,
 	)
 	require.NoError(t, err, "unable to init subSwapper")
 
@@ -226,8 +226,7 @@ func TestSubSwapperUpdater(t *testing.T) {
 	// With our channel set created, we'll make a fresh sub swapper
 	// instance to begin our test.
 	subSwapper, err := NewSubSwapper(
-		context.Background(), initialChanSet, chanNotifier, keyRing,
-		swapper,
+		t.Context(), initialChanSet, chanNotifier, keyRing, swapper,
 	)
 	require.NoError(t, err, "unable to make swapper")
 	if err := subSwapper.Start(); err != nil {

channeldb/addr_source_test.go

@@ -20,7 +20,7 @@ var (
 // deduplicates the results of a set of AddrSource implementations.
 func TestMultiAddrSource(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	var pk1 = newTestPubKey(t)
 

channeldb/db_test.go

@@ -1,7 +1,6 @@
 package channeldb
 
 import (
-	"context"
 	"image/color"
 	"math"
 	"math/rand"
@@ -181,7 +180,7 @@ func TestFetchClosedChannelForID(t *testing.T) {
 // channel db and graph db.
 func TestMultiSourceAddrsForNode(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	fullDB, err := MakeTestDB(t)
 	require.NoError(t, err, "unable to make test database")