chainrpc: return Unavailable while notifier starts

starius · starius · commit f4d6dc42cac5 · 2025-11-06T20:33:13.000-03:00
From v0.20.0-rc3 (commit c6f458e) onward the ChainNotifier sub-server may still be initialising when clients attempt to subscribe, currently resulting in a gRPC Unknown error with a plain-text message. Change the notifier RPC endpoints to return codes.Unavailable instead so clients can reliably interpret the condition as "retry later" and handle the startup lag without unstable string matching.
diff --git a/lnrpc/chainrpc/chain_server.go b/lnrpc/chainrpc/chain_server.go
@@ -84,8 +84,8 @@ var (
 
 	// ErrChainNotifierServerNotActive indicates that the chain notifier hasn't
 	// finished the startup process.
-	ErrChainNotifierServerNotActive = errors.New("chain notifier RPC is " +
-		"still in the process of starting")
+	ErrChainNotifierServerNotActive = status.Error(codes.Unavailable,
+		"chain notifier RPC is still in the process of starting")
 )
 
 // ServerShell is a shell struct holding a reference to the actual sub-server.

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,8 @@ var (`
`84`	`84`
`85`	`85`	`// ErrChainNotifierServerNotActive indicates that the chain notifier hasn't`
`86`	`86`	`// finished the startup process.`
`87`		`- ErrChainNotifierServerNotActive = errors.New("chain notifier RPC is " +`
`88`		`- "still in the process of starting")`
	`87`	`+ ErrChainNotifierServerNotActive = status.Error(codes.Unavailable,`
	`88`	`+ "chain notifier RPC is still in the process of starting")`
`89`	`89`	`)`
`90`	`90`
`91`	`91`	`// ServerShell is a shell struct holding a reference to the actual sub-server.`