set defaults and unblock unittests

Author: sjorsdonkers

src/cdp/domains/dom.zig

@@ -155,10 +155,10 @@ fn describeNode(cmd: anytype) !void {
         nodeId: ?Node.Id = null,
         backendNodeId: ?Node.Id = null,
         objectId: ?[]const u8 = null,
-        depth: ?u32 = null,
-        pierce: ?bool = null,
+        depth: u32 = 1,
+        pierce: bool = false,
     })) orelse return error.InvalidParams;
-    if (params.backendNodeId != null or params.depth != null or params.pierce != null) {
+    if (params.backendNodeId != null or params.depth != 1 or params.pierce) {
         return error.NotYetImplementedParams;
     }
 
@@ -169,12 +169,11 @@ fn describeNode(cmd: anytype) !void {
         return cmd.sendResult(.{ .node = bc.nodeWriter(node, .{}) }, .{});
     } else if (params.objectId != null) {
         const jsValue = try bc.session.inspector.getValueByObjectId(cmd.arena, params.objectId.?);
-        const entry = jsValue.externalEntry().?;
-        const sub_type = entry.sub_type.?;
 
-        if (!std.mem.eql(u8, sub_type[0..std.mem.len(sub_type)], "node")) {
-            return error.ObjectIdIsNotANode;
-        }
+        const entry = jsValue.externalEntry() orelse return error.ObjectIdIsNotANode;
+        const sub_type = entry.sub_type orelse return error.ObjectIdIsNotANode;
+        if (!std.mem.eql(u8, sub_type[0..std.mem.len(sub_type)], "node")) return error.ObjectIdIsNotANode;
+
         const node = try bc.node_registry.register(@ptrCast(entry.ptr));
         return cmd.sendResult(.{ .node = bc.nodeWriter(node, .{}) }, .{});
     }

src/cdp/testing.zig

@@ -107,10 +107,22 @@ const Session = struct {
     }
 };
 
+const Value = struct {
+    pub fn externalEntry(self: Value) ?*ExternalEntry {
+        _ = self;
+        return allocator.create(ExternalEntry) catch unreachable;
+    }
+};
+const ExternalEntry = struct {
+    ptr: *anyopaque,
+    sub_type: [*c]const u8 = null,
+};
+
 const Env = struct {
-    pub fn findOrAddValue(self: *Env, value: anytype) !@TypeOf(value) { // ?
+    pub fn findOrAddValue(self: *Env, value: anytype) !Value {
         _ = self;
-        return value;
+        _ = value;
+        return .{};
     }
 };
 
@@ -122,6 +134,12 @@ const Inspector = struct {
         _ = groupName;
         return RemoteObject{};
     }
+    pub fn getValueByObjectId(self: Inspector, alloc: std.mem.Allocator, object_id: []const u8) !Value {
+        _ = self;
+        _ = alloc;
+        _ = object_id;
+        return .{};
+    }
 };
 
 const RemoteObject = struct {