Skip to content

Commit 27e29e0

Browse files
committed
cdp: send the chrome's error on missing node
1 parent 3c7ebb3 commit 27e29e0

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/cdp/domains/dom.zig

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,9 @@ fn querySelectorAll(cmd: anytype) !void {
235235

236236
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
237237

238-
const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse return error.UnknownNode;
238+
const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse {
239+
return cmd.sendError(-32000, "Could not find node with given id", .{});
240+
};
239241

240242
const arena = cmd.arena;
241243
const selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);

0 commit comments

Comments
 (0)