Skip to content

Commit 2cdfc3f

Browse files
committed
setChildNodes checks
1 parent 4322d8e commit 2cdfc3f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/cdp/domains/dom.zig

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,9 @@ fn querySelectorAll(cmd: anytype) !void {
230230
const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse return error.UnknownNode;
231231

232232
const arena = cmd.arena;
233-
var selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);
234-
defer selected_nodes.deinit(arena);
235-
233+
const selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);
236234
const nodes = selected_nodes.nodes.items;
235+
237236
const node_ids = try arena.alloc(Node.Id, nodes.len);
238237
for (nodes, node_ids) |selected_node, *node_id| {
239238
node_id.* = (try bc.node_registry.register(selected_node)).id;
@@ -522,14 +521,14 @@ test "cdp.dom: querySelector Nodes found" {
522521
.method = "DOM.querySelector",
523522
.params = .{ .nodeId = 0, .selector = "p" },
524523
});
525-
// TODO Check 1 or more "DOM.setChildNodes" was send
524+
try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
526525
try ctx.expectSentResult(.{ .nodeId = 5 }, .{ .id = 4 });
527526

528527
try ctx.processMessage(.{
529528
.id = 5,
530529
.method = "DOM.querySelectorAll",
531530
.params = .{ .nodeId = 0, .selector = "p" },
532531
});
533-
// TODO Check 1 or more "DOM.setChildNodes" was send
532+
try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
534533
try ctx.expectSentResult(.{ .nodeIds = &.{5} }, .{ .id = 5 });
535534
}

0 commit comments

Comments
 (0)