Skip to content

Commit 39178d8

Browse files
committed
http: remove uselesss Client.arena
1 parent 7795916 commit 39178d8

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/http/Client.zig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ blocking: Handle,
8585
// To notify registered subscribers of events, the browser sets/nulls this for us.
8686
notification: ?*Notification = null,
8787

88-
// The only place this is meant to be used is in `makeRequest` BEFORE `perform`
89-
// is called. It is used to generate our Cookie header. It can be used for other
90-
// purposes, but keep in mind that, while single-threaded, calls like makeRequest
91-
// can result in makeRequest being re-called (from a doneCallback).
92-
arena: ArenaAllocator,
93-
9488
// only needed for CDP which can change the proxy and then restore it. When
9589
// restoring, this originally-configured value is what it goes to.
9690
http_proxy: ?[:0]const u8 = null,
@@ -128,7 +122,6 @@ pub fn init(allocator: Allocator, ca_blob: ?c.curl_blob, opts: Http.Opts) !*Clie
128122
.http_proxy = opts.http_proxy,
129123
.transfer_pool = transfer_pool,
130124
.queue_node_pool = queue_node_pool,
131-
.arena = ArenaAllocator.init(allocator),
132125
};
133126

134127
return client;
@@ -143,7 +136,6 @@ pub fn deinit(self: *Client) void {
143136

144137
self.transfer_pool.deinit();
145138
self.queue_node_pool.deinit();
146-
self.arena.deinit();
147139
self.allocator.destroy(self);
148140
}
149141

0 commit comments

Comments
 (0)