Skip to content

Commit 4c225e5

Browse files
server: let the caller of sendSync free the string
Signed-off-by: Francis Bouvier <[email protected]>
1 parent 9c913b2 commit 4c225e5

File tree

4 files changed

+3
-1
lines changed

4 files changed

+3
-1
lines changed

src/cdp/cdp.zig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ pub fn sendEvent(
207207
const resp = Resp{ .method = name, .params = params, .sessionId = sessionID };
208208

209209
const event_msg = try stringify(alloc, resp);
210+
defer alloc.free(event_msg);
210211
std.log.debug("event {s}", .{event_msg});
211212
try server.sendSync(ctx, event_msg);
212213
}

src/cdp/page.zig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ fn navigate(
269269
.loaderId = ctx.state.loaderID,
270270
};
271271
const res = try result(alloc, id orelse msg.id.?, Resp, resp, msg.sessionID);
272+
defer alloc.free(res);
272273
std.log.debug("res {s}", .{res});
273274
try server.sendSync(ctx, res);
274275

src/cdp/target.zig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ fn closeTarget(
308308
success: bool = true,
309309
};
310310
const res = try result(alloc, id orelse msg.id.?, Resp, Resp{}, null);
311+
defer alloc.free(res);
311312
try server.sendSync(ctx, res);
312313

313314
// Inspector.detached event

src/server.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ pub fn sendAsync(ctx: *Cmd, msg: []const u8) !void {
214214
}
215215

216216
pub fn sendSync(ctx: *Cmd, msg: []const u8) !void {
217-
defer ctx.alloc().free(msg);
218217
const s = try std.posix.write(ctx.socket, msg);
219218
std.log.debug("send sync {d} bytes", .{s});
220219
}

0 commit comments

Comments
 (0)