Merge pull request #540 from lightpanda-io/make-e2e

make: add end2end target

Author: krichprollsch

.github/workflows/e2e-test.yml

@@ -127,21 +127,8 @@ jobs:
 
       - run: chmod a+x ./lightpanda
 
-      - name: run puppeteer links
+      - name: run end to end tests
         run: |
           ./lightpanda serve & echo $! > LPD.pid
-          node puppeteer/links.js || exit 1
+          go run runner/main.go --verbose
           kill `cat LPD.pid`
-
-      - name: run puppeteer dump
-        run: |
-          ./lightpanda serve & echo $! > LPD.pid
-          node puppeteer/dump.js || exit 1
-          kill `cat LPD.pid`
-
-      - name: run playwright connect
-        run: |
-          python3 -m http.server 1234 -d ./public & echo $! > PYTHON.pid
-          ./lightpanda serve & echo $! > LPD.pid
-          node playwright/connect.js || exit 1
-          kill `cat LPD.pid` `cat PYTHON.pid`

Makefile

@@ -48,6 +48,7 @@ help:
 # $(ZIG) commands
 # ------------
 .PHONY: build build-dev run run-release shell test bench download-zig wpt data get-v8 build-v8 build-v8-dev
+.PHONY: end2end
 
 zig_version = $(shell grep 'recommended_zig_version = "' "vendor/zig-js-runtime/build.zig" | cut -d'"' -f2)
 
@@ -94,6 +95,11 @@ wpt-summary:
 test:
 	@TEST_FILTER='${F}' $(ZIG) build test -freference-trace --summary all
 
+## Run demo/runner end to end tests
+end2end:
+	@test -d ../demo
+	cd ../demo && go run runner/main.go
+
 ## v8
 get-v8:
 	@printf "\e[36mGetting v8 source...\e[0m\n"

README.md

@@ -229,7 +229,7 @@ First, get the tools necessary for building V8, as well as the V8 source code:
 make get-v8
 ```
 
-Next, build v8. This build task is very long and cpu consuming, as you will build v8 from sources. 
+Next, build v8. This build task is very long and cpu consuming, as you will build v8 from sources.
 
 ```
 make build-v8
@@ -243,6 +243,20 @@ For dev env, use `make build-v8-dev`.
 
 You can test Lightpanda by running `make test`.
 
+### End to end tests
+
+To run end to end tests, you need to clone the [demo
+repository](https://github.com/lightpanda-io/demo) into `../demo` dir.
+
+You have to install the [demo's node
+requirements](https://github.com/lightpanda-io/demo?tab=readme-ov-file#dependencies-1)
+
+You also need to install [Go](https://go.dev) > v1.24.
+
+```
+make end2end
+```
+
 ### Web Platform Tests
 
 Lightpanda is tested against the standardized [Web Platform