Merge pull request #607 from lightpanda-io/fix_int_overflow

karlseguin · web-flow · commit 690d4238e8a0 · 2025-05-07T16:05:37.000+08:00
fix overflow when setting timeout/interval
diff --git a/src/browser/html/window.zig b/src/browser/html/window.zig
@@ -165,7 +165,7 @@ pub const Window = struct {
         }
         errdefer _ = self.timers.remove(timer_id);
 
-        const delay: u63 = (delay_ orelse 0) * std.time.ns_per_ms;
+        const delay: u63 = @as(u63, (delay_ orelse 0)) * std.time.ns_per_ms;
         const callback = try arena.create(TimerCallback);
 
         callback.* = .{

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ pub const Window = struct {`
`165`	`165`	`}`
`166`	`166`	`errdefer _ = self.timers.remove(timer_id);`
`167`	`167`
`168`		`- const delay: u63 = (delay_ orelse 0) * std.time.ns_per_ms;`
	`168`	`+ const delay: u63 = @as(u63, (delay_ orelse 0)) * std.time.ns_per_ms;`
`169`	`169`	`const callback = try arena.create(TimerCallback);`
`170`	`170`
`171`	`171`	`callback.* = .{`