Skip to content

Commit 6d3065c

Browse files
authored
Merge pull request #1037 from lightpanda-io/upgrade_v8
Upgrade v8
2 parents 44c072d + 9092d1f commit 6d3065c

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.github/actions/install/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ inputs:
1717
zig-v8:
1818
description: 'zig v8 version to install'
1919
required: false
20-
default: 'v0.1.28'
20+
default: 'v0.1.30'
2121
v8:
2222
description: 'v8 version to install'
2323
required: false
24-
default: '13.6.233.8'
24+
default: '14.0.365.4'
2525
cache-dir:
2626
description: 'cache dir to use'
2727
required: false

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ FROM debian:stable
33
ARG MINISIG=0.12
44
ARG ZIG=0.15.1
55
ARG ZIG_MINISIG=RWSGOq2NVecA2UPNdBUZykf1CCb147pkmdtYxgb3Ti+JO/wCYvhbAb/U
6-
ARG V8=13.6.233.8
7-
ARG ZIG_V8=v0.1.28
6+
ARG V8=14.0.365.4
7+
ARG ZIG_V8=v0.1.30
88
ARG TARGETPLATFORM
99

1010
RUN apt-get update -yq && \

build.zig.zon

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
.fingerprint = 0xda130f3af836cea0,
66
.dependencies = .{
77
.v8 = .{
8-
.url = "https://github.com/lightpanda-io/zig-v8-fork/archive/d3040a953e5a37290dae20e7ddf138b7aeb5e67d.tar.gz",
9-
.hash = "v8-0.0.0-xddH6w_EAwA8vK0NAxfxfI7IcbnpkUAcXKNujn7qwnmY",
8+
.url = "https://github.com/lightpanda-io/zig-v8-fork/archive/7177ee1ae267a44751a0e7e012e257177699a375.tar.gz",
9+
.hash = "v8-0.0.0-xddH63TCAwC1D1hEiOtbEnLBbtz9ZPHrdiGWLcBcYQB7",
1010
},
11-
//.v8 = .{ .path = "../zig-v8-fork" }
11+
// .v8 = .{ .path = "../zig-v8-fork" }
1212
},
1313
}

src/runtime/test_object_types.zig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,8 @@ test "JS: object types" {
210210

211211
defer runner.deinit();
212212

213-
// v8 has 5 default "own" properties
214-
const own_base = "5";
213+
// v8 has 3 default "own" properties
214+
const own_base = "3";
215215

216216
try runner.testCases(&.{
217217
.{ "Object.getOwnPropertyNames(MyObject).length;", own_base },

0 commit comments

Comments
 (0)