Skip to content

Commit 7d96a25

Browse files
committed
try setting to weak instead of deinit
1 parent 4d1e416 commit 7d96a25

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/browser/fetch/fetch.zig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
170170
.done_callback = struct {
171171
fn doneCallback(ctx: *anyopaque) !void {
172172
const self: *FetchContext = @ptrCast(@alignCast(ctx));
173-
defer self.promise_resolver.deinit();
173+
defer self.promise_resolver.setWeak();
174174
self.transfer = null;
175175

176176
log.info(.fetch, "request complete", .{
@@ -187,7 +187,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
187187
.error_callback = struct {
188188
fn errorCallback(ctx: *anyopaque, err: anyerror) void {
189189
const self: *FetchContext = @ptrCast(@alignCast(ctx));
190-
defer self.promise_resolver.deinit();
190+
defer self.promise_resolver.setWeak();
191191
self.transfer = null;
192192

193193
log.err(.fetch, "error", .{

src/runtime/js.zig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,6 +2246,10 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
22462246
self.resolver.deinit();
22472247
}
22482248

2249+
pub fn setWeak(self: *PersistentPromiseResolver) void {
2250+
self.resolver.setWeak();
2251+
}
2252+
22492253
pub fn promise(self: PersistentPromiseResolver) Promise {
22502254
return .{
22512255
.promise = self.resolver.castToPromiseResolver().getPromise(),

0 commit comments

Comments
 (0)