Skip to content

Commit 8508c21

Browse files
cdp: remove send sync
Signed-off-by: Francis Bouvier <[email protected]>
1 parent 20dd140 commit 8508c21

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

src/cdp/cdp.zig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,7 @@ pub fn sendEvent(
225225
const resp = Resp{ .method = name, .params = params, .sessionId = sessionID };
226226

227227
const event_msg = try stringify(alloc, resp);
228-
defer alloc.free(event_msg);
229-
try server.sendSync(ctx, event_msg);
228+
try server.sendAsync(ctx, event_msg);
230229
}
231230

232231
fn getParams(

src/cdp/page.zig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,7 @@ fn navigate(
331331
.loaderId = ctx.state.loaderID,
332332
};
333333
const res = try result(alloc, msg.id, Resp, resp, msg.sessionID);
334-
defer alloc.free(res);
335-
try server.sendSync(ctx, res);
334+
try server.sendAsync(ctx, res);
336335

337336
// TODO: at this point do we need async the following actions to be async?
338337

src/cdp/target.zig

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,7 @@ fn disposeBrowserContext(
256256

257257
// output
258258
const res = try result(alloc, msg.id, null, .{}, null);
259-
defer alloc.free(res);
260-
try server.sendSync(ctx, res);
259+
try server.sendAsync(ctx, res);
261260

262261
return error.DisposeBrowserContext;
263262
}
@@ -345,8 +344,7 @@ fn closeTarget(
345344
success: bool = true,
346345
};
347346
const res = try result(alloc, msg.id, Resp, Resp{}, null);
348-
defer alloc.free(res);
349-
try server.sendSync(ctx, res);
347+
try server.sendAsync(ctx, res);
350348

351349
// Inspector.detached event
352350
const InspectorDetached = struct {

src/server.zig

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,8 @@ pub const Ctx = struct {
336336
tpl,
337337
.{ msg_open, cdp.ContextSessionID },
338338
);
339-
defer ctx.alloc().free(s);
340339

341-
try sendSync(ctx, s);
340+
try sendAsync(ctx, s);
342341
}
343342

344343
pub fn onInspectorResp(ctx_opaque: *anyopaque, _: u32, msg: []const u8) void {
@@ -401,10 +400,6 @@ pub fn sendAsync(ctx: *Ctx, msg: []const u8) !void {
401400
ctx.loop.io.send(*Send, sd, Send.asyncCbk, &sd.completion, ctx.conn_socket, msg);
402401
}
403402

404-
pub fn sendSync(ctx: *Ctx, msg: []const u8) !void {
405-
_ = try std.posix.write(ctx.conn_socket, msg);
406-
}
407-
408403
// Listen
409404
// ------
410405

0 commit comments

Comments
 (0)