Skip to content

Commit 8aac26a

Browse files
committed
cdp: check parameter's type on sendEvent
Disallow void type.
1 parent fc59a0f commit 8aac26a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/cdp/cdp.zig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,9 @@ pub fn sendEvent(
206206
params: T,
207207
sessionID: ?[]const u8,
208208
) !void {
209+
// some clients like chromedp expects empty parameters structs.
210+
if (T == void) @compileError("sendEvent: use struct{} instead of void for empty parameters");
211+
209212
log_cdp.debug("Event > method {s}, sessionID {?s}", .{ name, sessionID });
210213
const Resp = struct {
211214
method: []const u8,

0 commit comments

Comments
 (0)